refactor/pro-1160/remove-side-side-map

[Janislav]

Pull Request

Closes: PRO-1160

Checklist

Please conduct a thorough self-review before opening the PR.

• I am confident that the code works.
• I have updated documentation where appropriate.

Summary

Please include a succinct description of the purpose and content of the PR. What problem does it solve, and how? Link issues, discussions, other PRs, and anything else that will help the reviewer.

[codecov]

Codecov Report

Attention: 81 lines in your changes are missing coverage. Please review.

Comparison is base (cb12b67) 73% compared to head (27f29dc) 72%.
Report is 5 commits behind head on main.

❗ Current head 27f29dc differs from pull request most recent head f9e2297. Consider uploading reports for the commit f9e2297 to get more accurate results

Files	Patch %	Lines
state-chain/amm/src/lib.rs	42%	35 Missing ⚠️
state-chain/pallets/cf-pools/src/lib.rs	57%	25 Missing and 1 partial ⚠️
state-chain/amm/src/common.rs	85%	5 Missing and 2 partials ⚠️
state-chain/amm/src/range_orders.rs	80%	4 Missing ⚠️
state-chain/custom-rpc/src/lib.rs	0%	4 Missing ⚠️
state-chain/runtime/src/lib.rs	0%	0 Missing and 3 partials ⚠️
api/lib/src/lp.rs	0%	2 Missing ⚠️

Additional details and impacted files

@@          Coverage Diff           @@
##            main   #4489    +/-   ##
======================================
- Coverage     73%     72%    -0%     
======================================
  Files        401     399     -2     
  Lines      68209   67725   -484     
  Branches   68209   67725   -484     
======================================
- Hits       49617   49096   -521     
- Misses     15964   15972     +8     
- Partials    2628    2657    +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Janislav]

@AlastairHolmes for now I kept the term AssetsMap because I actually think it's not the worst name. I changed the Assets enum to Pairs. Maybe because of that, the terminology PoolPair could make sense?

[AlastairHolmes]

Can we also rename: "to_sold_side" to "to_sold_pair"

[AlastairHolmes]

@AlastairHolmes for now I kept the term AssetsMap because I actually think it's not the worst name. I changed the Assets enum to Pairs. Maybe because of that, the terminology PoolPair could make sense?

I like Pair/PoolPair, but wrt AssetsMap, I think its nice to keep consistently with the Map naming. So maybe (Pair, PairMap) / (Pairs, PairsMap) / (PoolPair, PoolPairMap) / (PoolPairs, PoolPairsMap)?

[AlastairHolmes]

Also we should rename "enum Order" to "Side" in this PR too.

[AlastairHolmes]

@AlastairHolmes for now I kept the term AssetsMap because I actually think it's not the worst name. I changed the Assets enum to Pairs. Maybe because of that, the terminology PoolPair could make sense?

I like Pair/PoolPair, but wrt AssetsMap, I think its nice to keep consistently with the Map naming. So maybe (Pair, PairMap) / (Pairs, PairsMap) / (PoolPair, PoolPairMap) / (PoolPairs, PoolPairsMap)?

Lets stick with the Plural "Pairs"/"PoolPairs", as I want to use "PoolPair" for something else.