Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add small v3 migration test #4543

Merged
merged 2 commits into from
Feb 19, 2024
Merged

test: add small v3 migration test #4543

merged 2 commits into from
Feb 19, 2024

Conversation

kylezs
Copy link
Contributor

@kylezs kylezs commented Feb 16, 2024

I was debugging #4490 and added this, might as well keep it.

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (acd6ac4) 73% compared to head (ff8fcd4) 73%.
Report is 1 commits behind head on main.

Files Patch % Lines
state-chain/pallets/cf-vaults/src/migrations/v3.rs 92% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main   #4543    +/-   ##
======================================
- Coverage     73%     73%    -0%     
======================================
  Files        401     401            
  Lines      68335   68209   -126     
  Branches   68335   68209   -126     
======================================
- Hits       49810   49624   -186     
- Misses     15905   15962    +57     
- Partials    2620    2623     +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kylezs kylezs enabled auto-merge (squash) February 19, 2024 07:44
@kylezs kylezs merged commit a4d42e8 into main Feb 19, 2024
43 checks passed
@kylezs kylezs deleted the test/key-migration branch February 19, 2024 08:05
syan095 added a commit that referenced this pull request Feb 26, 2024
…ero-liquidity

* origin/main: (28 commits)
  feat(custom-rpc): add broker info [WEB-925] (#4560)
  chore: upgrade solana version (#4567)
  fix: continuous adapter (PRO-684) (#4503)
  fix: Wait for ThresholdSignature success before switching to NewKeysActivated (#4534)
  chore: remove un-needed serde derives from EncodedAddress (#4565)
  fix: more lenient max deposit fee in bouncer test (#4564)
  chore: build persa bins instead of fetch (#4554)
  feat: deploy L2 contracts upon localnet startup and send L2 TXs 📑 (#4558)
  feat: debug logs on runtime upgrade test (#4556)
  feature/PRO-1038/pool-fee-rpc (#4459)
  chore: update bootnodes in chainspec ✨ (#4456)
  fix: allow test coverage to run (#4555)
  refactor/pro-1160/remove-side-side-map (#4489)
  fix: activate missing migrations (#4550)
  chore: remove cf-build (#4551)
  feat: extensible multi-key rotator (#4546)
  fix: ensure channel open fee can be paid in benchmarks (#4544)
  feat: bump substrate deps to polkadot-sdk 1.6 (#4504)
  fix: upgrade-test should restart the chainflip-nodes on an incompatible upgrade (#4490)
  test: add small v3 migration test (#4543)
  ...

# Conflicts:
#	state-chain/pallets/cf-pools/src/tests.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants