fix: take fee on to usdc #4801
Merged
fix: take fee on to usdc #4801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylezs
requested review from
AlastairHolmes,
dandanlen,
a team and
martin-chainflip
as code owners
kylezs
requested review from
ahasna,
xtroleum,
jerryafr and
GabrielBuragev
and removed request for
a team
kylezs
removed request for
dandanlen,
ahasna,
xtroleum,
jerryafr and
GabrielBuragev
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/1.3 #4801 +/- ##
===========================================
Coverage 72% 72%
===========================================
Files 403 403
Lines 67348 67387 +39
Branches 67348 67387 +39
===========================================
+ Hits 48684 48729 +45
Misses 16320 16320
+ Partials 2344 2338 -6 ☔ View full report in Codecov by Sentry. |
Comment on lines
749
to
752
| let stable_amount = *stable_amount; | ||
|
|
||
| if swap.to == STABLE_ASSET { | ||
| swap.final_output = Some(stable_amount); |
There was a problem hiding this comment.
Suggested change
| let stable_amount = *stable_amount; | |
| if swap.to == STABLE_ASSET { | |
| swap.final_output = Some(stable_amount); | |
| if swap.to == STABLE_ASSET { | |
| swap.final_output = Some(*stable_amount); |
There was a problem hiding this comment.
Does work, I tried it
AlastairHolmes
approved these changes
Apr 25, 2024
martin-chainflip
approved these changes
Apr 25, 2024
kylezs
added a commit
that referenced
this pull request
Apr 26, 2024
* fix: take network fee from output amount when swapping to stable * chore: set value directly * chore: bump runtime version * chore: clippy * chore: cleaner
syan095
added a commit
that referenced
this pull request
May 1, 2024
* origin/main: Arbitrum gas limit multiplier (#4781) fix: don't set code red on "agg-key set by gov-key" (#4813) fix: sign tx with correct key during rotation (#4794) chore: arbitrum witnesser permission (#4798) Solana (#4414) feat: try-runtime build step on dev ci (#4807) feat: optimistic build, streamlined ci-main (#4806) chore: log raw dispatch error (#4809) feat: allow for single binary CFE upgrades (#4634) fix: take fee on to usdc (#4801) (#4804) refactor: minor cleanup of retrier code and vault pallet (#4803) feat: cf_boost_pool_details rpc (#4780) # Conflicts: # Cargo.lock # state-chain/chains/src/sol.rs # state-chain/chains/src/sol/program_instructions.rs # state-chain/chains/src/sol/sol_tx_building_blocks.rs # state-chain/chains/src/sol/token_instructions.rs # state-chain/runtime/src/safe_mode.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.