fix: don't set code red on "agg-key set by gov-key" #4813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dandanlen
approved these changes
Apr 30, 2024
AlastairHolmes
force-pushed
the
fix/dont-set-code-red-automatically
branch
from
3c1a77a
to
6dd8a11
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4813 +/- ##
======================================
- Coverage 72% 72% -0%
======================================
Files 424 424
Lines 72319 72173 -146
Branches 72319 72173 -146
======================================
- Hits 52261 52045 -216
- Misses 17519 17588 +69
- Partials 2539 2540 +1 ☔ View full report in Codecov by Sentry. |
AlastairHolmes
force-pushed
the
fix/dont-set-code-red-automatically
branch
from
6dd8a11
to
6dde30f
Compare
remove test squash
AlastairHolmes
force-pushed
the
fix/dont-set-code-red-automatically
branch
from
6dde30f
to
8edd207
Compare
syan095
added a commit
that referenced
this pull request
May 1, 2024
* origin/main: Arbitrum gas limit multiplier (#4781) fix: don't set code red on "agg-key set by gov-key" (#4813) fix: sign tx with correct key during rotation (#4794) chore: arbitrum witnesser permission (#4798) Solana (#4414) feat: try-runtime build step on dev ci (#4807) feat: optimistic build, streamlined ci-main (#4806) chore: log raw dispatch error (#4809) feat: allow for single binary CFE upgrades (#4634) fix: take fee on to usdc (#4801) (#4804) refactor: minor cleanup of retrier code and vault pallet (#4803) feat: cf_boost_pool_details rpc (#4780) # Conflicts: # Cargo.lock # state-chain/chains/src/sol.rs # state-chain/chains/src/sol/program_instructions.rs # state-chain/chains/src/sol/sol_tx_building_blocks.rs # state-chain/chains/src/sol/token_instructions.rs # state-chain/runtime/src/safe_mode.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with Dan, we don't want to enable safe mode, when the agg-key is set by governance, as this is a normal situation (on new external chain contract deployment) and governance can independently set safe mode if required.
This also solves a problem were bouncer was intermittently failing, due to code red being set, on initializing Arbitrum.