Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to go1.22 and add goreleaser job checker #170

Closed
wants to merge 4 commits into from

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Apr 26, 2024

No description provided.

@cpanato cpanato changed the title Upgrade Upgrade to go1.22 and add goreleaser job checker Apr 26, 2024
Signed-off-by: cpanato <ctadeu@gmail.com>
@tstromberg
Copy link
Collaborator

@cpanato - I noticed this error in check_releaser:

⨯ release failed after 2s error=failed to build for darwin_amd64_v1: exit status 1: error obtaining VCS status: exit status 128 Use -buildvcs=false to disable VCS stamping.

Do you still want to merge this?

@cpanato
Copy link
Member Author

cpanato commented Apr 29, 2024

@cpanato - I noticed this error in check_releaser:

⨯ release failed after 2s error=failed to build for darwin_amd64_v1: exit status 1: error obtaining VCS status: exit status 128 Use -buildvcs=false to disable VCS stamping.

Do you still want to merge this?

we will merge if i can have a green check, otherwise no, but i am struggling in having a cross compiling for this, we might want to build in each runner platform, like, build mac on macos runner....

but for that and if we use goreleaser we will need a license, or give up on goreleaser and run in another way,

@tstromberg
Copy link
Collaborator

Ugh. I think the best thing to do is drop the binary release process for now.

After giving it some thought, I think binary images aren't going to be helpful for users - as few of them will have the right version of the dependency installed (libyara). I'd rather users just use the image or compile bincapz.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants