Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove release job, it does not work as is and need more things #179

Merged
merged 2 commits into from
May 2, 2024

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented May 2, 2024

related to #170

binary releases are currently difficult today due to the libyara C library dependency, specifically:

  • cross-compiling doesn't work w/ go-releaser
  • users are required to have the exact libyara version we compiled against to avoid crashes

For now, let's just direct end-users build the software themselves or use the image.

@cpanato cpanato requested a review from tstromberg May 2, 2024 14:31
@tstromberg tstromberg enabled auto-merge (squash) May 2, 2024 14:47
@tstromberg tstromberg merged commit 4149741 into chainguard-dev:main May 2, 2024
8 checks passed
@cpanato cpanato deleted the remove-job branch May 2, 2024 15:33
@egibs
Copy link
Member

egibs commented May 3, 2024

Bummer. I can spend some cycles on figuring this out.

@cpanato
Copy link
Member Author

cpanato commented May 3, 2024

we need to build in a dedicated runner for now to avoid cross-compilation, which will be a bit harder, but if we use Goreleaser, we will need a paid license to use the split build option. i will figure out something

egibs pushed a commit to egibs/malcontent that referenced this pull request Aug 5, 2024
egibs pushed a commit to egibs/malcontent that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants