Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TTD support for externals with a prototype #4719

Merged
merged 1 commit into from
Feb 22, 2018
Merged

TTD support for externals with a prototype #4719

merged 1 commit into from
Feb 22, 2018

Conversation

kfarnung
Copy link
Contributor

No description provided.

@kfarnung kfarnung self-assigned this Feb 21, 2018
@kfarnung kfarnung mentioned this pull request Feb 21, 2018
Merged
2 tasks
boingoing
boingoing approved these changes Feb 21, 2018
View reviewed changes
Copy link
Contributor

@boingoing boingoing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mike-kaufman
mike-kaufman approved these changes Feb 21, 2018
View reviewed changes
Copy link
Contributor

@mike-kaufman mike-kaufman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chakrabot chakrabot merged commit 51cd5ab into chakra-core:release/1.9 Feb 22, 2018
chakrabot pushed a commit that referenced this pull request Feb 22, 2018
@kfarnung
[MERGE #4719 @kfarnung] TTD support for externals with a prototype
aef2cfa 
Merge pull request #4719 from kfarnung:externalttd
@kfarnung kfarnung deleted the externalttd branch February 22, 2018 00:26
chakrabot pushed a commit that referenced this pull request Feb 22, 2018
@kfarnung
[1.9>master] [MERGE #4719 @kfarnung] TTD support for externals with a…
2a25773 
… prototype

Merge pull request #4719 from kfarnung:externalttd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boingoing boingoing boingoing approved these changes

@mike-kaufman mike-kaufman mike-kaufman approved these changes

@obastemur obastemur Awaiting requested review from obastemur

@mrkmarron mrkmarron Awaiting requested review from mrkmarron

Assignees

@kfarnung kfarnung

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kfarnung @boingoing @mike-kaufman @chakrabot