This repository has been archived by the owner on Oct 15, 2020. It is now read-only.
chakrashim: Use JsCreateExternalObjectWithPrototype #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I adopted #429, assuming @obastemur is ok with this, we can close his PR. |
kfarnung
commented
Feb 21, 2018
| return Local<Object>(); | ||
| } | ||
| &prototype) != JsNoError) { | ||
| prototype = nullptr; |
There was a problem hiding this comment.
I went back and forth on this, I largely think it's unnecessary, but I landed on the safe side.
|
@kfarnung Thanks |
Previously, Chakrashim was calling both JsCreateExternalObject and JsSetPrototype. JsSetPrototype is expensive to lazy call. Use combined JsCreateExternalObjectWithPrototype instead. PR-URL: nodejs#472 Refs: nodejs#429 Reviewed-By: Taylor Woll <tawoll@ntdev.microsoft.com> Reviewed-By: Oguz Bastemur <ogbastem@microsoft.com>
kfarnung
pushed a commit
to kfarnung/node-chakracore
that referenced
this pull request
Feb 23, 2018
Previously, Chakrashim was calling both JsCreateExternalObject and JsSetPrototype. JsSetPrototype is expensive to lazy call. Use combined JsCreateExternalObjectWithPrototype instead. PR-URL: nodejs#472 Refs: nodejs#429 Reviewed-By: Taylor Woll <tawoll@ntdev.microsoft.com> Reviewed-By: Oguz Bastemur <ogbastem@microsoft.com>
kfarnung
pushed a commit
to kfarnung/node-chakracore
that referenced
this pull request
Mar 6, 2018
Previously, Chakrashim was calling both JsCreateExternalObject and JsSetPrototype. JsSetPrototype is expensive to lazy call. Use combined JsCreateExternalObjectWithPrototype instead. PR-URL: nodejs#472 Refs: nodejs#429 Reviewed-By: Taylor Woll <tawoll@ntdev.microsoft.com> Reviewed-By: Oguz Bastemur <ogbastem@microsoft.com>
kfarnung
pushed a commit
to kfarnung/node-chakracore
that referenced
this pull request
Mar 7, 2018
Previously, Chakrashim was calling both JsCreateExternalObject and JsSetPrototype. JsSetPrototype is expensive to lazy call. Use combined JsCreateExternalObjectWithPrototype instead. PR-URL: nodejs#472 Refs: nodejs#429 Reviewed-By: Taylor Woll <tawoll@ntdev.microsoft.com> Reviewed-By: Oguz Bastemur <ogbastem@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, Chakrashim was calling both JsCreateExternalObject and JsSetPrototype.
JsSetPrototype is expensive to lazy call. Use combined JsCreateExternalObjectWithPrototype instead
This depends on the changes in chakra-core/ChakraCore#4719 landing first to prevent TTD breaks.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
chakrashim