-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add scripts from cli #680
Merged
Merged
add scripts from cli #680
Changes from 2 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,35 +1,42 @@ | ||
<!DOCTYPE html> | ||
<html lang="en"> | ||
<head> | ||
<head> | ||
<meta charset="utf-8"> | ||
<meta name="viewport" content="width=device-width, initial-scale=1"> | ||
<title>cellxgene</title> | ||
<link href="https://fonts.googleapis.com/css?family=Roboto+Condensed:400,400i,700" rel="stylesheet"> | ||
<style> | ||
html, body, p, h1, h2, h3, h4, h5, h6, span, button, input, label, text, div { | ||
font-family: 'Roboto Condensed','Helvetica Neue','Helvetica','Arial',sans-serif; | ||
font-size: 14px; | ||
} | ||
body { | ||
margin: 0; | ||
padding: 0; | ||
} | ||
html, body, p, h1, h2, h3, h4, h5, h6, span, button, input, label, text, div { | ||
font-family: 'Roboto Condensed', 'Helvetica Neue', 'Helvetica', 'Arial', sans-serif; | ||
font-size: 14px; | ||
} | ||
|
||
* { | ||
box-sizing: border-box; | ||
} | ||
body { | ||
margin: 0; | ||
padding: 0; | ||
} | ||
|
||
* { | ||
box-sizing: border-box; | ||
} | ||
</style> | ||
</head> | ||
<body> | ||
|
||
</head> | ||
<body> | ||
<script type="text/javascript"> | ||
window.CELLXGENE = {}; | ||
window.CELLXGENE.API = { | ||
prefix: window.location.href + "api/", | ||
version: "v0.2/" | ||
}; | ||
window.CELLXGENE = {}; | ||
window.CELLXGENE.API = { | ||
prefix: window.location.href + "api/", | ||
version: "v0.2/" | ||
}; | ||
</script> | ||
<noscript>If you're seeing this message, that means <strong>JavaScript has been disabled on your browser</strong>, please <strong>enable JS</strong> to make this app work.</noscript> | ||
<noscript>If you're seeing this message, that means <strong>JavaScript has been disabled on your browser</strong>, | ||
please <strong>enable JS</strong> to make this app work. | ||
</noscript> | ||
|
||
<div id="root"></div> | ||
</body> | ||
<div id="root"></div> | ||
{% for script in SCRIPTS %} | ||
<script type="text/javascript" src="{{script | safe}}"></script> | ||
{% endfor %} | ||
</body> | ||
</html> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would further make people type in a confirmation that they understand this message before spawning the browser.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have users who want to deploy in a docker-deployed environment, ie, scripted startup where they have control over the deployment script. I like Tony's suggestion, but we need to ensure that the confirmation can be scripting (eg, pipe
yes
to it, or whatever). Alternative to "|yes": provide a--I-attest-that-really-mean-to-inject-scripts
CLI param that still prints the warning, but dispenses with the interactive prompt. @ttung - thoughts?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should be able to add this such that
| yes
works.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either way is fine. The browser being fired up is sufficient, I believe, for bad stuff to run, so I do think the confirmation is important, at least for the first time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added confirm.
yes | cellxgene launch --scripts foo --scripts bar example-dataset/pbmc3k.h5ad
bypasses the confirm as expected.