Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(link): create link specific t3 tokens #1632

Merged
merged 5 commits into from
May 30, 2023
Merged

Conversation

jinlee93
Copy link
Contributor

@jinlee93 jinlee93 commented May 25, 2023

EDS-985

Summary:

Test Plan:

  • CI tests / new tests are not applicable
    • no visual regressions

@jinlee93 jinlee93 requested a review from a team May 25, 2023 01:50
@jinlee93
Copy link
Contributor Author

jinlee93 commented May 25, 2023

A little WIP due to possibly needing to add border tokens or change text-decoration name to border via sync with design

synced

@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #1632 (f4ca870) into next (a3cda57) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             next    #1632      +/-   ##
==========================================
+ Coverage   93.25%   93.28%   +0.03%     
==========================================
  Files         222      222              
  Lines        2935     2949      +14     
  Branches      717      717              
==========================================
+ Hits         2737     2751      +14     
  Misses        181      181              
  Partials       17       17              
Impacted Files Coverage Δ
src/tokens-dist/ts/colors.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented May 25, 2023

size-limit report 📦

Path Size
components 95.01 KB (0%)
styles 36.37 KB (+0.44% 🔺)

booc0mtaco
booc0mtaco previously approved these changes May 25, 2023
Copy link
Contributor

@booc0mtaco booc0mtaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this require changes to theming token definitions in themed projects?

@booc0mtaco booc0mtaco dismissed their stale review May 26, 2023 13:39

too early

@jinlee93 jinlee93 marked this pull request as ready for review May 26, 2023 16:32
@jinlee93 jinlee93 changed the title refactor(link): create link specific t3 tokens refactor(link)!: create link specific t3 tokens May 26, 2023
@jinlee93
Copy link
Contributor Author

jinlee93 commented May 26, 2023

Will this require changes to theming token definitions in themed projects?

@booc0mtaco I can make the tokens refer to the previously used t2 tokens to make this unbreaking but would be brittle since t2 token names don't exactly align and design assumes it is not referencing t2

Referencing t2 tokens for now and batching breaking changes later

@jinlee93 jinlee93 changed the title refactor(link)!: create link specific t3 tokens refactor(link): create link specific t3 tokens May 26, 2023
Copy link
Contributor

@booc0mtaco booc0mtaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The end state is that these t2 tokens will be deleted, if i recall. If so, we can mark those as deprecated via comments

@jinlee93 jinlee93 merged commit 1f7fdb4 into next May 30, 2023
@jinlee93 jinlee93 deleted the jlee/linkt3tokens branch May 30, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants