Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rfc: RPC through unix socket #34

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Jan 12, 2022

Signed-off-by: YangKeao yangkeao@chunibyo.icu

rendered

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@YangKeao
Copy link
Member Author

@STRRL @Hexilee PTAL

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Copy link
Member

@Hexilee Hexilee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, It seems interesting! I would like to implement it as I'm going to refactor the bpm.

@YangKeao
Copy link
Member Author

@Hexilee FYI, the latest version of nsexec (v0,1,7) has implemented a keep-fd argument to pass fd to the subprocess.

@STRRL
Copy link
Member

STRRL commented Jan 13, 2022

PTAL @craig-seeman @Colstuwjx

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@YangKeao YangKeao requested a review from a team January 14, 2022 04:39
@RandyLambert
Copy link

I am interested in doing this idea. I am a senior student at Xi'an University of Posts and Telecommunications. The main language I use is C/C++/GO. I am familiar with operating systems, distributed, network programming, and system programming.

@Hexilee
Copy link
Member

Hexilee commented Feb 17, 2022

I am interested in doing this idea. I am a senior student at Xi'an University of Posts and Telecommunications. The main language I use is C/C++/GO. I am familiar with operating systems, distributed, network programming, and system programming.

@RandyLambert Welcome! As you are the first time to contribute, it would be better to work on good first issue to be familiar with Chaos Mesh. More resources about how to contribute can be found in CONTRIBUTING.md and our developer guide.

@RandyLambert
Copy link

我有兴趣做这个想法。我是西安邮电大学的一名大四学生。我使用的主要语言是 C/C++/GO。我熟悉操作系统、分布式、网络编程和系统编程。

@RandyLambert欢迎!由于您是第一次投稿,所以最好在第一个问题上工作以熟悉 Chaos Mesh。更多关于如何贡献的资源可以在CONTRIBUTING.md和我们的开发者指南中找到。

Thank you, I'll go back and try to do a little work


## Motivation

The chaos-daemon communicates with `rs-tproxy`, `toda`... with stdin/stdout.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it is chaos-tproxy here.


2. Dial abstract unix socket directly (rather than passing fd).

Unfortunately, the abstract unix socket is binded with the network namespace,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer this & actually we have access to mnt namespace of pod in chaos-daemon on proc file system.

@xlgao-zju
Copy link
Member

this is cool.
but I am wondering will this change increase the usage of resource?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants