Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to unix domain socket #36

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

RandyLambert
Copy link

@RandyLambert RandyLambert commented Jul 8, 2022

  • Remove jsonrpc and jsonrpc_test

Signed-off-by: RandyLambert randylambert@foxmail.com

  • Update Cargo.toml

Signed-off-by: RandyLambert randylambert@foxmail.com

Signed-off-by: RandyLambert randylambert@foxmail.com

  • upgrade tokio

Signed-off-by: RandyLambert randylambert@foxmail.com

RandyLambert and others added 2 commits July 8, 2022 18:18
* Remove jsonrpc and jsonrpc_test

Signed-off-by: shouxunsun <1randylambert@gmail.com>

* Update Cargo.toml

Signed-off-by: shouxunsun <1randylambert@gmail.com>

* rpc Use unix domain socket

Signed-off-by: shouxunsun <1randylambert@gmail.com>

* upgrade tokio

Signed-off-by: shouxunsun <1randylambert@gmail.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Co-authored-by: Yang Keao <keao.yang@yahoo.com>
Signed-off-by: RandyLambert <randylambert@foxmail.com>
* Use std::thread::spawn instead of tokio::spawn to solve there is no reactor running error

Signed-off-by: shouxunsun <1randylambert@gmail.com>

Co-authored-by: Yang Keao <keao.yang@yahoo.com>
Co-authored-by: xixi <i@hexilee.me>
Signed-off-by: RandyLambert <randylambert@foxmail.com>
RandyLambert and others added 4 commits August 1, 2022 02:17
* use unix domain socket with path

Signed-off-by: RandyLambert <randylambert@foxmail.com>
* use unix domain socket with path

Signed-off-by: RandyLambert <randylambert@foxmail.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
* use unix domain socket with path

Signed-off-by: RandyLambert <randylambert@foxmail.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
* use unix domain socket with path

Signed-off-by: RandyLambert <randylambert@foxmail.com>
Copy link
Member

@Hexilee Hexilee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM, please execute cargo fmt and fix cargo clippy before committing.

src/cmd/interactive/handler.rs Outdated Show resolved Hide resolved
src/cmd/interactive/handler.rs Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
src/signal.rs Outdated Show resolved Hide resolved
src/cmd/interactive/handler.rs Outdated Show resolved Hide resolved
src/cmd/interactive/handler.rs Outdated Show resolved Hide resolved
src/cmd/interactive/handler.rs Outdated Show resolved Hide resolved
@Hexilee Hexilee requested a review from YangKeao September 7, 2022 05:31
@Hexilee
Copy link
Member

Hexilee commented Sep 7, 2022

PTAL @YangKeao @RandyLambert

* use unix domain socket with path

Signed-off-by: RandyLambert <randylambert@foxmail.com>
* use unix domain socket with path

Signed-off-by: RandyLambert <randylambert@foxmail.com>
* use unix domain socket with path

Signed-off-by: RandyLambert <randylambert@foxmail.com>
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

src/hookfs/mod.rs Outdated Show resolved Hide resolved
* use unix domain socket with path

Signed-off-by: RandyLambert <randylambert@foxmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants