-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change to unix domain socket #36
Open
RandyLambert
wants to merge
10
commits into
chaos-mesh:master
Choose a base branch
from
RandyLambert:change-to-unix-domain-socket
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Change to unix domain socket #36
RandyLambert
wants to merge
10
commits into
chaos-mesh:master
from
RandyLambert:change-to-unix-domain-socket
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove jsonrpc and jsonrpc_test Signed-off-by: shouxunsun <1randylambert@gmail.com> * Update Cargo.toml Signed-off-by: shouxunsun <1randylambert@gmail.com> * rpc Use unix domain socket Signed-off-by: shouxunsun <1randylambert@gmail.com> * upgrade tokio Signed-off-by: shouxunsun <1randylambert@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> Co-authored-by: Yang Keao <keao.yang@yahoo.com> Signed-off-by: RandyLambert <randylambert@foxmail.com>
* Use std::thread::spawn instead of tokio::spawn to solve there is no reactor running error Signed-off-by: shouxunsun <1randylambert@gmail.com> Co-authored-by: Yang Keao <keao.yang@yahoo.com> Co-authored-by: xixi <i@hexilee.me> Signed-off-by: RandyLambert <randylambert@foxmail.com>
RandyLambert
force-pushed
the
change-to-unix-domain-socket
branch
from
July 8, 2022 10:19
dce49c9
to
08a9f9d
Compare
* use unix domain socket with path Signed-off-by: RandyLambert <randylambert@foxmail.com>
* use unix domain socket with path Signed-off-by: RandyLambert <randylambert@foxmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
* use unix domain socket with path Signed-off-by: RandyLambert <randylambert@foxmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
* use unix domain socket with path Signed-off-by: RandyLambert <randylambert@foxmail.com>
Hexilee
requested changes
Sep 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM, please execute cargo fmt
and fix cargo clippy
before committing.
PTAL @YangKeao @RandyLambert |
Hexilee
reviewed
Sep 8, 2022
11 tasks
* use unix domain socket with path Signed-off-by: RandyLambert <randylambert@foxmail.com>
* use unix domain socket with path Signed-off-by: RandyLambert <randylambert@foxmail.com>
* use unix domain socket with path Signed-off-by: RandyLambert <randylambert@foxmail.com>
YangKeao
approved these changes
Sep 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
* use unix domain socket with path Signed-off-by: RandyLambert <randylambert@foxmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: RandyLambert randylambert@foxmail.com
Signed-off-by: RandyLambert randylambert@foxmail.com
Signed-off-by: RandyLambert randylambert@foxmail.com
Signed-off-by: RandyLambert randylambert@foxmail.com