river: fetching submodules directly into flake.nix #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has been built and cached successfully! All changed derivations have built successfully. |
github-actions
bot
added
cached
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes simplify the process of fetching submodules for River by directly specifying the submodule URL in the flake.nix file. The previous approach of using a separate JSON file and update script is no longer needed.
The issue arose because the original nixpkgs package the
src.fetchSubmodules = trueis used, it turns out that the behavior was not replicated by the way the River was declared in flake.nix, #153. Regrettably, there is no equivalent declaration, likeinputs.src-name.fetchSubmodules = true. Fortunately, a helpful contributor NixOS/nix#4423 (comment) recently provided a solution.