Dev3.2.0 #463
Merged
Dev3.2.0 #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h state.assigned every time
Anytime annealing update
Use a filter, instead of a set subtraction, to avoid iterating through state.assigned every time
Two other instances where a set subtraction operation would be faster as a filter
Dev3.2.0
Removed the observation init from MH. This means that the sampler might start from a state that violates the conditions, but the models is still in a valid state (ie, valid according to its generative model). This fix also uncovered another MH bug that was found from the decision tests. In the MultiDecisionTest example, it was recording decisions values and expected utilities for non-valid combinations. Meaning, the expected utility of a decision was a value that was not possible based on the model. It turns out that this bug has to do with the update function in MH. This function was repeatedly visiting elements to update, but not in the correct order. I couldn't figure out the exact nature of the bug, but when you have a model with A->B and (A,B)->C, you would get B updated, then C, then B again. This was incorrect. The solution is I just rewrote the updateMany function to do a recursive pass through the dependencies. Visiting elements in generative order is a repeated operation throughout Figaro (MH, IS, Forward sampling) and we really should create a unified visiting method for all algorithms.
Fix OnlineEM bug (#461)
Fix OnlineEM bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.