Line feed in vim code block rendered as error #257
Comments
PratikBhusal
added a commit
to PratikBhusal/glow
that referenced
this issue
Feb 19, 2024
…al/glamour" Ran the following command: ```sh go get github.com/PratikBhusal/glamour@bb4d1e719da4a9e8063f17b676c4bc15d4ad645f rg "github.com/charmbracelet/glamour" -l -0 | xargs -0 sed -i 's/github.com\/charmbracelet\/glamour/github.com\/PratikBhusal\/glamour/g' go mod tidy ``` Fixes: charmbracelet/glamour#257 Fixes: charmbracelet#485
caarlos0
added a commit
that referenced
this issue
Jul 16, 2024
|
this was fixed on master. thanks! - and sorry for the delay! |
|
Great, thanks 👍 |
caarlos0
added a commit
that referenced
this issue
Jul 25, 2024
* wip Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * wip * wip * wip * fix: autolink closes #290 * fix: escape characters closes #106 closes #274 closes #311 * fix: table * ci: golangci lint update * feat: use x/golden * test: #106 Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * test: #290 Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * test: #312 Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * test: #257 Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * test: #149 * fix: #239 * feat: use lipgloss table closes #262 Co-authored-by: bashbunni <bunni@bashbunni.dev> * fix: codespan is not a block * test: #315 * test: #316 * fix: #316 * test: table * fix: codespans, tables * test: table * test: #117 * test: #60 * fix: rm stylewriter * fix: #313 * fix: margin * fix: blocks and word wrap * fix: build Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * chore: gitattributes * fix: test opt Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * fix: stable lipgloss Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * fix: double styles * fix: tables * fix: tables --------- Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> Co-authored-by: bashbunni <bunni@bashbunni.dev>
bashbunni
added a commit
that referenced
this issue
Jul 31, 2024
* wip Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * wip * wip * wip * fix: autolink closes #290 * fix: escape characters closes #106 closes #274 closes #311 * fix: table * ci: golangci lint update * feat: use x/golden * test: #106 Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * test: #290 Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * test: #312 Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * test: #257 Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * test: #149 * fix: #239 * feat: use lipgloss table closes #262 Co-authored-by: bashbunni <bunni@bashbunni.dev> * fix: codespan is not a block * test: #315 * test: #316 * fix: #316 * test: table * fix: codespans, tables * test: table * test: #117 * test: #60 * fix: rm stylewriter * fix: #313 * fix: margin * fix: blocks and word wrap * fix: build Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * chore: gitattributes * fix: test opt Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * fix: stable lipgloss Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * fix: double styles * fix: tables * fix: tables --------- Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> Co-authored-by: bashbunni <bunni@bashbunni.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Glamour renders \n as visible error when rendering VimL code blocks. This is due to lexer bug in Chroma, now fixed, but yet to be released, combined with the code block error style in Glamour rendering errors with a red background (rather than Chroma default of using red text).
See alecthomas/chroma#827 for more info
Upgrading the Chroma dependency could address this, but the latest stable release, 2.8.0, does not include the fix.
What is the best approach to solving this? Just wait for a stable Chroma release including the fix and then open a PR to bump the Chroma version in Glamour?
The text was updated successfully, but these errors were encountered: