fix: many rendering issues #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maaslalani
approved these changes
Jul 16, 2024
closes #262 Co-authored-by: bashbunni <bunni@bashbunni.dev>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
aymanbagabas
approved these changes
Jul 22, 2024
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
|
I think this one is still broken It also looks like there may be an issue with tables rendering properly source markdown: We still need to fix these hard new lines as well... though could be done in another PR |
|
this table breaks on glow, but not on glamour... weird, investigating... |
|
i think this is all fixed. need to use this branch of glow: charmbracelet/glow#631 |
bashbunni
added a commit
that referenced
this pull request
Jul 31, 2024
* wip Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * wip * wip * wip * fix: autolink closes #290 * fix: escape characters closes #106 closes #274 closes #311 * fix: table * ci: golangci lint update * feat: use x/golden * test: #106 Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * test: #290 Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * test: #312 Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * test: #257 Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * test: #149 * fix: #239 * feat: use lipgloss table closes #262 Co-authored-by: bashbunni <bunni@bashbunni.dev> * fix: codespan is not a block * test: #315 * test: #316 * fix: #316 * test: table * fix: codespans, tables * test: table * test: #117 * test: #60 * fix: rm stylewriter * fix: #313 * fix: margin * fix: blocks and word wrap * fix: build Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * chore: gitattributes * fix: test opt Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * fix: stable lipgloss Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * fix: double styles * fix: tables * fix: tables --------- Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> Co-authored-by: bashbunni <bunni@bashbunni.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing many bug related to rendering, most of them come from the fact we don't render inner elements properly.
This fixes it.
closes #312
closes #290
closes #106
closes #274
closes #311
closes #239
closes #262
closes #254
closes #315
closes #316
refs #149
closes #117
closes #60
closes #313
closes #237
refs #107 (improves it a little bit, doesn't fix it though)
refs #79 (improves it a little bit, doesn't fix it though)
closes #68
refs #172