Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tea): set the color profile once #159

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Conversation

aymanbagabas
Copy link
Member

Set the global color profile once out of the middleware. We don't need to set the value every time the middleware is called. This also adds a comment about the behavior.

Set the global color profile once out of the middleware. We don't need
to set the value every time the middleware is called.
This also adds a comment about the behavior.
@aymanbagabas aymanbagabas requested a review from caarlos0 July 27, 2023 00:29
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #159 (bf81d93) into main (0b49def) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #159   +/-   ##
=======================================
  Coverage   76.14%   76.14%           
=======================================
  Files          17       17           
  Lines         897      897           
=======================================
  Hits          683      683           
  Misses        160      160           
  Partials       54       54           

Copy link
Member

@caarlos0 caarlos0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah we really need to get #132 out

@aymanbagabas aymanbagabas merged commit dcc6e56 into main Jul 27, 2023
@aymanbagabas aymanbagabas deleted the multiple-color-profiles branch July 27, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants