feat: allow to user a termenv renderer on bubbletea middleware #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #132 +/- ##
=======================================
Coverage 76.14% 76.14%
=======================================
Files 17 17
Lines 897 897
=======================================
Hits 683 683
Misses 160 160
Partials 54 54 |
|
will wait muesli/termenv#122 before working more on this one |
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
|
depends on charmbracelet/bubbletea#739 |
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
|
superseded by #197 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this allows the bubbletea middleware to query the user terminal instead of using the server (or the default).
It'll also give the user a
*lipgloss.Rendererwhich can be used with lipgloss directly, etc.Tried to make it so it isn't a breaking change.
TODO:
Example is very based on @aymanbagabas & @meowgorithm work on https://github.com/charmbracelet/lipgloss/blob/master/examples/ssh/main.go
closes #71 #45
needs
charmbracelet/bubbletea#720charmbracelet/bubbletea#715