feat: use real pty #197

caarlos0 · 2023-12-04T18:29:13Z

This allows to allocate a real PTY for the session, allowing to do things like running vim within a SSH session.

~~depends on charmbracelet/bubbletea#879~~
depends on charmbracelet/ssh#8
closes #196

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

codecov · 2023-12-04T18:32:06Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d2fab68) 76.40% compared to head (20ca97a) 76.40%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #197   +/-   ##
=======================================
  Coverage   76.40%   76.40%           
=======================================
  Files          17       17           
  Lines         907      907           
=======================================
  Hits          693      693           
  Misses        160      160           
  Partials       54       54

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

aymanbagabas

If we're going to do that, we have to remove the ssh PtyWriter hack, and detect the color profile from the PTY https://github.com/charmbracelet/wish/pull/197/files#diff-79d3f1c4cf631bd3e71a422f4d73666477d1caa5b44e965c98d80e6551f4f8cfR93

caarlos0 · 2023-12-07T17:11:00Z

If we're going to do that, we have to remove the ssh PtyWriter hack, and detect the color profile from the PTY https://github.com/charmbracelet/wish/pull/197/files#diff-79d3f1c4cf631bd3e71a422f4d73666477d1caa5b44e965c98d80e6551f4f8cfR93

Can be done in another PR, as its not strictly related

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

caarlos0 · 2024-01-04T18:42:25Z

still pending changes on ssh cc/ @aymanbagabas

bubbletea/tea.go

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

Co-authored-by: Ayman Bagabas <ayman.bagabas@gmail.com> Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

based on #219 Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> Co-authored-by: Ayman Bagabas <ayman.bagabas@gmail.com>

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

bubbletea/tea.go

bubbletea/tea_other.go

bubbletea/tea_unix.go

Co-authored-by: Ayman Bagabas <ayman.bagabas@gmail.com> Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

bubbletea/tea.go

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

caarlos0 · 2024-01-18T02:25:36Z

anyone against this not being a breaking change anymore?

aymanbagabas · 2024-01-18T11:19:19Z

anyone against this not being a breaking change anymore?

LGTM

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

matthewp · 2024-01-28T13:14:36Z

@caarlos0 Do you plan on doing a release for this?

feat: use pty

0b36a69

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

caarlos0 added the enhancement New feature or request label Dec 4, 2023

caarlos0 requested a review from aymanbagabas December 4, 2023 18:29

caarlos0 self-assigned this Dec 4, 2023

fix: deps

aa0bb66

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

caarlos0 mentioned this pull request Dec 4, 2023

Bubbletea ExecProcess within a wish session #196

Closed

fix: deps

fc89255

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

aymanbagabas reviewed Dec 4, 2023

View reviewed changes

caarlos0 added 3 commits December 4, 2023 17:28

fix: update example

0868b14

fix: deps

46447ee

docs: fix example

9ba7e36

caarlos0 added 2 commits December 8, 2023 09:33

feat: pass lipgloss.Renderer down to the tea.App

ab27fe2

Merge remote-tracking branch 'origin/main' into using-pty

020651e

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

caarlos0 changed the title ~~feat: use real pty~~ feat!: use real pty Dec 8, 2023

caarlos0 added 4 commits December 12, 2023 09:13

Merge remote-tracking branch 'origin/main' into using-pty

c6e19fc

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

fix: go mod tidy

a70d0bd

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

improvements

fd4337e

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

Merge remote-tracking branch 'origin/main' into using-pty

488fd2f

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

aymanbagabas reviewed Jan 4, 2024

View reviewed changes

bubbletea/tea.go Outdated Show resolved Hide resolved

caarlos0 and others added 2 commits January 4, 2024 21:55

Merge remote-tracking branch 'origin/main' into using-pty

c9ad8ee

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

fix: pty

83cc777

Co-authored-by: Ayman Bagabas <ayman.bagabas@gmail.com> Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

caarlos0 force-pushed the using-pty branch from 8d5c9c2 to 83cc777 Compare January 5, 2024 01:06

caarlos0 and others added 5 commits January 4, 2024 22:10

fix: better diff

60e8254

chore: typo

2cf714d

fix: godocs

59c5884

fix: allocate pty on macos

9ab015a

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

fix: improvements

50a706e

based on #219 Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> Co-authored-by: Ayman Bagabas <ayman.bagabas@gmail.com>

caarlos0 added 2 commits January 8, 2024 18:18

chore: godoc

411f301

Merge remote-tracking branch 'origin/main' into using-pty

9d68adf

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

aymanbagabas reviewed Jan 9, 2024

View reviewed changes

bubbletea/tea.go Outdated Show resolved Hide resolved

bubbletea/tea.go Outdated Show resolved Hide resolved

bubbletea/tea_other.go Outdated Show resolved Hide resolved

bubbletea/tea_unix.go Outdated Show resolved Hide resolved

caarlos0 and others added 8 commits January 9, 2024 12:54

fix: review

47074ac

Co-authored-by: Ayman Bagabas <ayman.bagabas@gmail.com> Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

fix: example

5e7f41a

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

fix: tea program handler

4c7fb4f

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

fix: examples

0431178

Merge remote-tracking branch 'origin/main' into using-pty

aed4f59

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

Merge remote-tracking branch 'origin/main' into using-pty

c40b251

refactor: improve p!=nil handling

d7ee1ec

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

fix: ensure session envs are available to renderer (#223)

c0d4269

aymanbagabas approved these changes Jan 9, 2024

View reviewed changes

bubbletea/tea.go Outdated Show resolved Hide resolved

caarlos0 added 3 commits January 9, 2024 21:43

fix: rename func to makeoptions

73189b2

fix: not too much breaking

569d089

chore: fix gitignore

b0c56ba

caarlos0 mentioned this pull request Jan 17, 2024

feat: allow to user a termenv renderer on bubbletea middleware #132

Closed

1 task

caarlos0 added 2 commits January 17, 2024 16:05

Merge remote-tracking branch 'origin/main' into using-pty

c9668e0

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

fix: dep

91c322b

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

fix: update charmbracelet/ssh

cd60d40

caarlos0 changed the title ~~feat!: use real pty~~ feat: use real pty Jan 18, 2024

caarlos0 added 3 commits January 18, 2024 14:32

fix: update dep

12a7a6a

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

chore: go mod tidy

731c66e

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

chore: update example

20ca97a

caarlos0 merged commit 7f44d6d into main Jan 18, 2024
14 checks passed

caarlos0 deleted the using-pty branch January 18, 2024 18:14

caarlos0 mentioned this pull request Jan 18, 2024

Color issues when running the program under a systemd service #45

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: use real pty #197

feat: use real pty #197

caarlos0 commented Dec 4, 2023 •

edited

Loading

codecov bot commented Dec 4, 2023 •

edited

Loading

aymanbagabas left a comment

caarlos0 commented Dec 7, 2023

caarlos0 commented Jan 4, 2024

caarlos0 commented Jan 18, 2024

aymanbagabas commented Jan 18, 2024

matthewp commented Jan 28, 2024

feat: use real pty #197

feat: use real pty #197

Conversation

caarlos0 commented Dec 4, 2023 • edited Loading

codecov bot commented Dec 4, 2023 • edited Loading

Codecov Report

aymanbagabas left a comment

Choose a reason for hiding this comment

caarlos0 commented Dec 7, 2023

caarlos0 commented Jan 4, 2024

caarlos0 commented Jan 18, 2024

aymanbagabas commented Jan 18, 2024

matthewp commented Jan 28, 2024

caarlos0 commented Dec 4, 2023 •

edited

Loading

codecov bot commented Dec 4, 2023 •

edited

Loading