Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add wish.Command and wish.Cmd #229

Merged
merged 13 commits into from
Jan 30, 2024
Merged

feat: add wish.Command and wish.Cmd #229

merged 13 commits into from
Jan 30, 2024

Commits on Jan 22, 2024

  1. feat: add wish.Command and wish.Cmd

    The wish-exec example with vim worked because neovim was not using
    STDERR.
    
    Bubbletea doesn't have a concept of stdout and stderr, just output, so
    `tea.ExecProcess` sets the `exec.Cmd` stderr to `os.Stderr`.
    
    This would fail for bash, for instance.
    
    This also introduces a `wish.Cmd` type and a `wish.Command`
    function to properly set up a `wish.Cmd` based on `ssh.Session` (and
    optionally a Pty), which can then be used with `tea.Exec`.
    
    Finally, it adds to the wish-exec example, including the `s` key to run
    a shell (bash).
    
    closes #228
    
    Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
    caarlos0 committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    6b83fbb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b76e30a View commit details
    Browse the repository at this point in the history
  3. refactory: move things around a bit

    Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
    caarlos0 committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    15c8f2f View commit details
    Browse the repository at this point in the history
  4. fix: loop

    caarlos0 committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    5b50e2e View commit details
    Browse the repository at this point in the history
  5. test: add some tests

    Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
    caarlos0 committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    f8bb3d1 View commit details
    Browse the repository at this point in the history
  6. test: more tests

    Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
    caarlos0 committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    0d769ae View commit details
    Browse the repository at this point in the history
  7. test: more tests

    Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
    caarlos0 committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    7491d08 View commit details
    Browse the repository at this point in the history
  8. fix: improve tests

    Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
    caarlos0 committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    ee092f0 View commit details
    Browse the repository at this point in the history
  9. test: windows

    Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
    caarlos0 committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    0b7f07c View commit details
    Browse the repository at this point in the history
  10. fix: review

    Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
    caarlos0 committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    32aeafc View commit details
    Browse the repository at this point in the history
  11. fix: improve cmd

    caarlos0 committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    1681ea4 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. fix: create a new pty for exec.Cmd (#230)

    * fix: create a new pty for exec.Cmd
    
    Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
    
    * fix: improvements
    
    * fix: test
    
    * fix: windows
    
    Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
    
    * fix: unneeded err
    
    Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
    
    * fix
    
    Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
    
    * fix: resize && race
    
    Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
    
    * fix: windows/linux
    
    Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
    
    * test: ignore on windows for now
    
    Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
    
    * fix: sync
    
    Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
    
    * test: hammer
    
    Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
    
    * chore: import
    
    ---------
    
    Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
    caarlos0 authored Jan 26, 2024
    Configuration menu
    Copy the full SHA
    98030fa View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. fix: update ssh

    Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
    caarlos0 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    10790a8 View commit details
    Browse the repository at this point in the history