-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add wish.Command and wish.Cmd #229
Merged
Merged
Commits on Jan 22, 2024
-
feat: add wish.Command and wish.Cmd
The wish-exec example with vim worked because neovim was not using STDERR. Bubbletea doesn't have a concept of stdout and stderr, just output, so `tea.ExecProcess` sets the `exec.Cmd` stderr to `os.Stderr`. This would fail for bash, for instance. This also introduces a `wish.Cmd` type and a `wish.Command` function to properly set up a `wish.Cmd` based on `ssh.Session` (and optionally a Pty), which can then be used with `tea.Exec`. Finally, it adds to the wish-exec example, including the `s` key to run a shell (bash). closes #228 Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 6b83fbb - Browse repository at this point
Copy the full SHA 6b83fbbView commit details -
Configuration menu - View commit details
-
Copy full SHA for b76e30a - Browse repository at this point
Copy the full SHA b76e30aView commit details -
refactory: move things around a bit
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 15c8f2f - Browse repository at this point
Copy the full SHA 15c8f2fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b50e2e - Browse repository at this point
Copy the full SHA 5b50e2eView commit details -
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for f8bb3d1 - Browse repository at this point
Copy the full SHA f8bb3d1View commit details -
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 0d769ae - Browse repository at this point
Copy the full SHA 0d769aeView commit details -
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 7491d08 - Browse repository at this point
Copy the full SHA 7491d08View commit details -
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for ee092f0 - Browse repository at this point
Copy the full SHA ee092f0View commit details -
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 0b7f07c - Browse repository at this point
Copy the full SHA 0b7f07cView commit details -
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 32aeafc - Browse repository at this point
Copy the full SHA 32aeafcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1681ea4 - Browse repository at this point
Copy the full SHA 1681ea4View commit details
Commits on Jan 26, 2024
-
fix: create a new pty for exec.Cmd (#230)
* fix: create a new pty for exec.Cmd Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * fix: improvements * fix: test * fix: windows Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * fix: unneeded err Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * fix Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * fix: resize && race Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * fix: windows/linux Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * test: ignore on windows for now Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * fix: sync Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * test: hammer Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * chore: import --------- Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 98030fa - Browse repository at this point
Copy the full SHA 98030faView commit details
Commits on Jan 29, 2024
-
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 10790a8 - Browse repository at this point
Copy the full SHA 10790a8View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.