Update node-versions and streamline tempestApi.js code #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update node-version: [16.x, 18.x, 20.x], remove 14.x which is no longer supported by homebridge.
See CHANGELOG.md for details of this update.
Reference CHANGELOG.md for summary of changes.
Combine 2 PRs into single PR.
Add check if return `obs` data is string.
|
Chase, looks like you have approved but not merged this PR. Still remains stable on my end. Regards, Doug |
* Update node-version: [18.x, 20.x, 22.x], remove 16.x which is no longer supported by homebridge. * Reformated `getStationObservation()` and `getStationCurrentObservation()` in `tempestApi.ts`. * Addresses `observation_data is undefined, skipping update` error in `platform.ts` polling loop.
Update README.md to update link for Homebridge logo.
chasenicholl
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See CHANGELOG.md for details of this change.