Move to npm #420

RomanNikitenko · 2024-09-19T09:47:57Z

What does this PR do?

move che-code to npm
align che-code with upstream

What issues does this PR fix?

eclipse-che/che#23122

How to test this PR?

PR jobs should be green
testing of any use cases is useful as we pick up a lot of commits from the upstream

I found that the che-code launcher logic was definitely affected, so I've tested the following use cases:

load static webview resources with the editor from the same domain, see fix: load static webview resources with the editor from the same domain #411
extension secrets should not be lost when workspace restart, see fix: extension secrets should not be lost when workspace restart #340
browser database name should contain a valid DevWorkspace identifier, see chore: browser database name should contain a valid DevWorkspace identifier #273

Does this PR contain changes that override default upstream Code-OSS behavior?

the PR contains changes in the code folder (you can skip it if your changes are placed in a che extension )
the corresponding items were added to the CHANGELOG.md file
rules for automatic git rebase were added to the .rebase folder

github-actions · 2024-09-19T09:48:07Z

Click here to review and test in web IDE:

github-actions · 2024-09-24T17:46:47Z

Pull Request images published ✨

Editor: quay.io/che-incubator-pull-requests/che-code:pr-420-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-420-dev-amd64

github-actions · 2024-09-25T09:04:18Z

Pull Request images published ✨

Editor: quay.io/che-incubator-pull-requests/che-code:pr-420-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-420-dev-amd64

Move inlin chat buttons to one toolbar

By allowing an optional providerId passed in. Fixes microsoft/vscode#229503

Fixes microsoft/vscode#226892

* Fix invisible chat view after updating to compatible extension * Fix #228011 Use new API for chat welcome view

Fixes #229494

fix hover navigation across attachments

…9802) This reverts commit 11fb5bb. Add another context key `inlineChatPossible` which truely checks code editors so that a global command works

…9805)

…806) using backgrounds instead of underline

* Redo the way an edit session gets disposed and add more assertions to catch any incorrect usages * Fix lifecycle issues, also don't capture in the click closure the initial contents of the editing session

Fixes #229808

disable more exploreer async find features

Don't make workbench.panel.showLabel visible

github-actions · 2024-09-26T12:57:35Z

Pull Request images published ✨

Editor: quay.io/che-incubator-pull-requests/che-code:pr-420-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-420-dev-amd64

fix attachment in other attachments render location...

Part of microsoft/vscode#229808

Fixes #229557

fixes microsoft/vscode-copilot#8509

Don't await clipboard image data when not supported

Signed-off-by: RomanNikitenko <rnikiten@redhat.com>

github-actions · 2024-10-07T14:21:33Z

Pull Request images published ✨

Editor: quay.io/che-incubator-pull-requests/che-code:pr-420-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-420-dev-amd64

github-actions · 2024-10-07T14:32:32Z

Pull Request images published ✨

Editor: quay.io/che-incubator-pull-requests/che-code:pr-420-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-420-dev-amd64

rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED

github-actions · 2024-10-15T10:56:19Z

Pull Request images published ✨

Editor: quay.io/che-incubator-pull-requests/che-code:pr-420-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-420-dev-amd64

rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED

github-actions · 2024-10-16T14:38:56Z

Pull Request images published ✨

Editor: quay.io/che-incubator-pull-requests/che-code:pr-420-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-420-dev-amd64

rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED

github-actions · 2024-10-17T10:55:34Z

Pull Request images published ✨

Editor: quay.io/che-incubator-pull-requests/che-code:pr-420-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-420-dev-amd64

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED

github-actions · 2024-10-18T06:23:26Z

Pull Request images published ✨

Editor: quay.io/che-incubator-pull-requests/che-code:pr-420-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-420-dev-amd64

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED

rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED

github-actions · 2024-10-23T06:24:50Z

Pull Request images published ✨

Editor: quay.io/che-incubator-pull-requests/che-code:pr-420-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-420-dev-amd64

devstudio-release · 2024-10-30T09:24:36Z

Build 3.18 :: code_3.x/1490: Console, Changes, Git Data

devstudio-release · 2024-10-30T09:30:32Z

Build 3.18 :: code_3.x/1491: Console, Changes, Git Data

RomanNikitenko force-pushed the move-to-npm branch 2 times, most recently from 4ed8f15 to 5753014 Compare September 20, 2024 19:21

roblourens and others added 18 commits September 26, 2024 01:01

Move inline chat buttons to one toolbar (#229776)

3b5eba0

Move inlin chat buttons to one toolbar

Handle when an extension hasn't used an auth provider yet (#229777)

6801c1f

By allowing an optional providerId passed in. Fixes microsoft/vscode#229503

Fix #229667. Bind listeners on cell text model misses events. (#229773)

749615f

Use select_account prompt when no account is specified (#229778)

eef6488

Fixes microsoft/vscode#226892

Use new API for chat welcome view (#229782)

2fddfda

* Fix invisible chat view after updating to compatible extension * Fix #228011 Use new API for chat welcome view

feat: enable file decorations for chat edited files list

037dadc

feat: render edit generation progress in chat editing widget

c43f508

Only the first settings reference in a line is rendered (#229727)

9e23739

Fixes #229494

Fix hover navigation across attachments (#229801)

a45ae99

fix hover navigation across attachments

Revert "Revert "chat command center polish (#229674)" (#229755)" (#22…

67a93b0

…9802) This reverts commit 11fb5bb. Add another context key `inlineChatPossible` which truely checks code editors so that a global command works

Cancelling application of edits results in a dialog notification (#22…

9a91d33

…9805)

Using different backgrounds on composition instead of underline (#229…

31afbe3

…806) using backgrounds instead of underline

Fix editing session lifecycle issues (#229807)

8252865

* Redo the way an edit session gets disposed and add more assertions to catch any incorrect usages * Fix lifecycle issues, also don't capture in the click closure the initial contents of the editing session

Fix bracket pair + tree-sitter freeze (#229809)

516cd37

Fixes #229808

Disable more explorer async find features (#229814)

438a9d9

disable more exploreer async find features

fix #229488 (#229816)

c48773b

fix how context key is updated (#229818)

be760b0

Hide panel icon rendering feature (#229817)

a3c6381

Don't make workbench.panel.showLabel visible

benibenj and others added 6 commits September 26, 2024 16:35

Fix hovers in chat attachments 2 (#229831)

a6139a4

fix attachment in other attachments render location...

Fix some off-by-one at the end of the line in tree sitter (#229833)

c68420a

Part of microsoft/vscode#229808

Emit change event when the state changes to streaming (#229834)

ced91ac

Missed a spot with highlighting member methods (#229836)

7b238be

Fixes #229557

reveal chat zone should always reveal position in editor (#229838)

178c125

fixes microsoft/vscode-copilot#8509

Do not await clipboard image data when not supported (#229835)

2544a7b

Don't await clipboard image data when not supported

chore: Use npm when automatic rebasing rules are applied

b0f2aa3

Signed-off-by: RomanNikitenko <rnikiten@redhat.com>

RomanNikitenko marked this pull request as ready for review October 8, 2024 09:56

RomanNikitenko requested review from azatsarynnyy and vitaliy-guliy as code owners October 8, 2024 09:56

azatsarynnyy approved these changes Oct 8, 2024

View reviewed changes

RomanNikitenko force-pushed the move-to-npm branch from 105c414 to 7085610 Compare October 15, 2024 08:59

RomanNikitenko added 2 commits October 15, 2024 12:32

Merge remote-tracking branch 'eclipse/main' into move-to-npm

61867a6

rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED

chore: Adapt PR-428 changes to npm

9a5ebe4

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED

RomanNikitenko force-pushed the move-to-npm branch from 7085610 to 9a5ebe4 Compare October 15, 2024 09:53

Merge remote-tracking branch 'eclipse/main' into move-to-npm

8ce4d0d

rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED

RomanNikitenko added 2 commits October 17, 2024 11:24

Merge remote-tracking branch 'eclipse/main' into move-to-npm

cfc3198

rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED

chore: Adapt PR-436 to npm

20ceef3

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED

chore: fix npm timeouts for dockerfiles

e3963a3

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED

RomanNikitenko added 4 commits October 22, 2024 19:29

chore: Add root lock file

2c67e29

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED

chore: Regenerate lock files for che extensions

9c378b3

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED

Merge remote-tracking branch 'eclipse/main' into move-to-npm

9167f0a

rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED

chore: Update lock files after resolving conflicts

c279bdd

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED

vitaliy-guliy approved these changes Oct 25, 2024

View reviewed changes

RomanNikitenko mentioned this pull request Oct 29, 2024

Adapt Devspaces-Code to use npm for build redhat-developer/devspaces-images#650

Merged

RomanNikitenko merged commit 6739ad2 into che-incubator:main Oct 30, 2024
6 of 7 checks passed

RomanNikitenko deleted the move-to-npm branch October 30, 2024 07:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move to npm #420

Move to npm #420

RomanNikitenko commented Sep 19, 2024 •

edited

Loading

github-actions bot commented Sep 19, 2024 •

edited

Loading

github-actions bot commented Sep 24, 2024

github-actions bot commented Sep 25, 2024

github-actions bot commented Sep 26, 2024

github-actions bot commented Oct 7, 2024

github-actions bot commented Oct 7, 2024

github-actions bot commented Oct 15, 2024

github-actions bot commented Oct 16, 2024

github-actions bot commented Oct 17, 2024

github-actions bot commented Oct 18, 2024

github-actions bot commented Oct 23, 2024

devstudio-release commented Oct 30, 2024

devstudio-release commented Oct 30, 2024

Move to npm #420

Move to npm #420

Conversation

RomanNikitenko commented Sep 19, 2024 • edited Loading

What does this PR do?

What issues does this PR fix?

How to test this PR?

Does this PR contain changes that override default upstream Code-OSS behavior?

github-actions bot commented Sep 19, 2024 • edited Loading

github-actions bot commented Sep 24, 2024

github-actions bot commented Sep 25, 2024

github-actions bot commented Sep 26, 2024

github-actions bot commented Oct 7, 2024

github-actions bot commented Oct 7, 2024

github-actions bot commented Oct 15, 2024

github-actions bot commented Oct 16, 2024

github-actions bot commented Oct 17, 2024

github-actions bot commented Oct 18, 2024

github-actions bot commented Oct 23, 2024

devstudio-release commented Oct 30, 2024

devstudio-release commented Oct 30, 2024

RomanNikitenko commented Sep 19, 2024 •

edited

Loading

github-actions bot commented Sep 19, 2024 •

edited

Loading