-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt Devspaces-Code to use npm for build #650
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomanNikitenko
force-pushed
the
move-code-to-npm
branch
2 times, most recently
from
October 15, 2024 09:59
1d68781
to
efee735
Compare
RomanNikitenko
changed the title
Adapt Devspaces-Code Dockerfile to build using npm
Adapt Devspaces-Code to use npm for build
Oct 16, 2024
RomanNikitenko
force-pushed
the
move-code-to-npm
branch
4 times, most recently
from
October 18, 2024 09:25
3f8fd85
to
f66acc2
Compare
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED
RomanNikitenko
force-pushed
the
move-code-to-npm
branch
from
October 29, 2024 13:06
6fe003e
to
67aabc3
Compare
RomanNikitenko
requested review from
svor,
ibuziuk and
SDawley
as code owners
October 29, 2024 13:06
I've got a successful build for |
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED
SDawley
reviewed
Oct 29, 2024
SDawley
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move Devspaces-Code npm build.
Upstream changes: che-incubator/che-code#420
Signed-off-by: Roman Nikitenko rnikiten@redhat.com
rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED