Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt Devspaces-Code to use npm for build #650

Merged
merged 8 commits into from
Oct 30, 2024

Conversation

RomanNikitenko
Copy link
Contributor

@RomanNikitenko RomanNikitenko commented Oct 10, 2024

Move Devspaces-Code npm build.
Upstream changes: che-incubator/che-code#420

Signed-off-by: Roman Nikitenko rnikiten@redhat.com

rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED

@RomanNikitenko RomanNikitenko force-pushed the move-code-to-npm branch 2 times, most recently from 1d68781 to efee735 Compare October 15, 2024 09:59
@RomanNikitenko RomanNikitenko changed the title Adapt Devspaces-Code Dockerfile to build using npm Adapt Devspaces-Code to use npm for build Oct 16, 2024
@RomanNikitenko RomanNikitenko force-pushed the move-code-to-npm branch 4 times, most recently from 3f8fd85 to f66acc2 Compare October 18, 2024 09:25
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>

rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>

rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>

rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>

rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED
@RomanNikitenko
Copy link
Contributor Author

I've got a successful build for x86_64 platform on brew,
I'm testing the same changes for s390x and ppc64le platforms...

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>

rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED
@RomanNikitenko RomanNikitenko merged commit 3761616 into devspaces-3-rhel-8 Oct 30, 2024
@RomanNikitenko RomanNikitenko deleted the move-code-to-npm branch October 30, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants