feat: Allow to use OpenVSX instance from the plug-in registry #85
Conversation
benoitf
requested review from
azatsarynnyy,
RomanNikitenko and
vzhukovs
as code owners
benoitf
changed the title
|
Pull Request images published ✨ |
build/scripts/entrypoint-volume.sh
Outdated
| OPENVSX_URL="$CHE_PLUGIN_REGISTRY_ROOT_URL/openvsx/vscode" | ||
| sed -i -r -e "s|\"serviceUrl\": \"..*\"|\"serviceUrl\": \"${OPENVSX_URL}/gallery\"|" product.json | ||
| sed -i -r -e "s|\"itemUrl\": \"..*\"|\"itemUrl\": \"${OPENVSX_URL}/item\"|" product.json | ||
| sed -i -e "s|serviceUrl:\".*\",itemUrl:\".*\"},version|serviceUrl:\"${OPENVSX_URL}/gallery\",itemUrl:\"${OPENVSX_URL}/item\"},version|" vs/workbench/workbench.web.main.js |
There was a problem hiding this comment.
When the initcontainer is stated I get in the logs:
sed: can't read vs/workbench/workbench.web.main.js: No such file or directory
and locally
$ docker run -ti --entrypoint cat quay.io/che-incubator-pull-requests/che-code:pr-85-amd64 /checode/checode-linux-libc/vs/workbench/workbench.web.main.js
cat: /checode/checode-linux-libc/vs/workbench/workbench.web.main.js: No such file or directory
There was a problem hiding this comment.
there is a missing out prefix
out/vs/workbench/workbench.web.main.js
|
Pull Request images published ✨ |
|
Pull Request images published ✨ |
|
Pull Request images published ✨ |
|
Pull Request images published ✨ |
empty: use OpenVSX from the plug-in registry defined: use that link Change-Id: I9c349f435a399e23c38819e9f3d2d80e7b9a85b0 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
|
Pull Request images published ✨ |
2 similar comments
|
Pull Request images published ✨ |
|
Pull Request images published ✨ |
There was a problem hiding this comment.
I've tested and it works as expected. There 4 extensions, as it's configured in https://github.com/eclipse-che/che-plugin-registry/blob/main/openvsx-sync.json
If OpenVSX URL is empty, use the OpenVSX from the plug-in registry, else use the link provided (that should be open-vsx.org)
Requires eclipse-che/che-plugin-registry#1324
Part of eclipse-che/che#20549
Fixes eclipse-che/che#21601
Should then be updated to match new fields of CheCluster CR eclipse-che/che#21598
you can see in top left that extensions are coming from the che plug-in registry URL
Change-Id: I9c349f435a399e23c38819e9f3d2d80e7b9a85b0
Signed-off-by: Florent Benoit fbenoit@redhat.com