Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: synchronise proto bindings with the latest version of CRIU RPC p… #137

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

yevzman-swe
Copy link
Contributor

@yevzman-swe yevzman-swe commented Jul 11, 2023

rpc: synchronise proto bindings with the latest version of CRIU RPC

@yevzman-swe
Copy link
Contributor Author

@rst0git can you review PR?

@adrianreber
Copy link
Member

Did you sync the changes from the CRIU release branch or criu-dev?

@yevzman-swe
Copy link
Contributor Author

Did you sync the changes from the CRIU release branch or criu-dev?

I sync the changes from the criu-dev branch.

@adrianreber
Copy link
Member

Did you sync the changes from the CRIU release branch or criu-dev?

I sync the changes from the criu-dev branch.

Do you need those changes? I think we try to stay on the release branches of CRIU and not the criu-dev branch (if not necessary).

@snprajwal
Copy link
Member

snprajwal commented Jul 18, 2023

The master branch of criu seems to have had some changes. You can update the commit with the new bindings by running rm rpc/rpc.proto && make rpc/rpc.pb.go

@yevzman-swe
Copy link
Contributor Author

yevzman-swe commented Jul 18, 2023

support for flags in runc will be pushed in runc)

Did you sync the changes from the CRIU release branch or criu-dev?

I sync the changes from the criu-dev branch.

Do you need those changes? I think we try to stay on the release branches of CRIU and not the criu-dev branch (if not necessary).

I need these changes to be able to use these flags in the runc checky runc) point/restore process. (support for flags in runc will be followed bpoint/restore process. (support for flags in runc will be pushed in runc)

@yevzman-swe
Copy link
Contributor Author

The master branch of criu seems to have had some changes. You can update the commit with the new bindings by running rm rpc/rpc.proto && make rpc/rpc.pb.go

Unfortunately, these changes are not included in the CRIU master branch

@adrianreber
Copy link
Member

Works for me. With all the changes currently going on we will not create a release in the next couple of weeks, but I think we can merge this. @rst0git PTAL

@rst0git
Copy link
Member

rst0git commented Jul 20, 2023

@yevzman-swe Note that to use the go-criu changes with runc, you would need to install CRIU from the criu-dev branch, or to wait for the next CRIU release that provides these changes.

Signed-off-by: Yan Evzman <yevzman@gmail.com>
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f8745d1) 50.34% compared to head (dd89489) 50.34%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #137   +/-   ##
=======================================
  Coverage   50.34%   50.34%           
=======================================
  Files          24       24           
  Lines        2590     2590           
=======================================
  Hits         1304     1304           
  Misses       1102     1102           
  Partials      184      184           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rst0git rst0git merged commit fe8a627 into checkpoint-restore:master Jul 20, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants