Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rpc): update Go bindings #139

Merged
merged 2 commits into from
Jul 22, 2023

Conversation

snprajwal
Copy link
Member

@snprajwal snprajwal commented Jul 20, 2023

The rpc.proto file has been updated against criu-dev, but not the bindings. Makes #137 work, and also updates protobuf with it.

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (fe8a627) 50.34% compared to head (9700254) 50.34%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #139   +/-   ##
=======================================
  Coverage   50.34%   50.34%           
=======================================
  Files          24       24           
  Lines        2590     2590           
=======================================
  Hits         1304     1304           
  Misses       1102     1102           
  Partials      184      184           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

rpc/rpc.pb.go Show resolved Hide resolved
Signed-off-by: Prajwal S N <prajwalnadig21@gmail.com>
The rpc.pb.go bindings have been updated against the proto file.
Additionally, the other bindings have also been updated with protobuf
v23.4.

Signed-off-by: Prajwal S N <prajwalnadig21@gmail.com>
Copy link
Member

@rst0git rst0git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rst0git rst0git merged commit 4b74590 into checkpoint-restore:master Jul 22, 2023
14 checks passed
@snprajwal snprajwal deleted the update-rpc branch August 8, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants