Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for render quote card #81

Merged
merged 2 commits into from
May 22, 2023
Merged

Conversation

cheehwatang
Copy link
Owner

@cheehwatang cheehwatang commented May 22, 2023

Type of Change

  • ✅ New Test

Description

  • add test for renderQuoteCard.ts
  • update codecov threshold to 2%

Related Tickets & Documents

How Has This Been Tested?

  • renderQuoteCard method is tested to see if the values are passed to QuoteCard.build.

Added or Updated Tests?

  • 👍 Yes

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added proof(eg. screenshots) that prove my fix is effective or that my feature works
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@vercel
Copy link

vercel bot commented May 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
github-readme-daily-quotes ✅ Ready (Inspect) Visit Preview May 22, 2023 0:03am

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #81 (6bbd1a7) into master (911067b) will increase coverage by 7.93%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
+ Coverage   50.79%   58.73%   +7.93%     
==========================================
  Files          12       12              
  Lines         126      126              
  Branches       11       11              
==========================================
+ Hits           64       74      +10     
+ Misses         61       51      -10     
  Partials        1        1              

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cheehwatang cheehwatang merged commit 8f4b23d into master May 22, 2023
@cheehwatang cheehwatang deleted the add-test-for-render-quote-card branch May 22, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test for renderQuoteCard.ts
1 participant