.removeClass() should remove all occurrences of class name #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Although I agree, I think it's more important to provide a consistent API with jQuery. If jQuery adapts this, I'll be happy to implement this change. |
|
That makes sense. I've opened a ticket in jQuery's issue tracker. |
|
ping @matthewmueller |
|
Finally reviewed and merged this in. Thanks man. |
|
Excellent! |
This was referenced Aug 16, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're currently in line with jQuery (as of 1.7.2, at least), but in my view this behaviour is erroneous:
.removeClass()should remove all occurrences of the class name. I'm happy to create a pull request if you agree.