Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in removeClass (null ref) #84

Merged
merged 3 commits into from
Aug 19, 2012

Conversation

robashton
Copy link
Contributor

I think this came in #64

So... the behaviour I'm seeing is something like, I have

<li class="card view template">
</li>
<li>

</li>

And this is in a blob of HTML

I call

 $(html).removeClass('template')

and I get a null ref exception because 'class' is null (in the second list item I guess)

I think the fix is as simple as the pull request attached to this commit, but I will admit I haven't made too much attempt to understand what is going on :)

@travisbot
Copy link

This pull request passes (merged b9897cb into 1b140b3).

@matthewmueller
Copy link
Member

Ahh, thanks for spotting this - any chance you could update the unit test?

@robashton
Copy link
Contributor Author

Yeah, if the fix looks right I'll do that

@travisbot
Copy link

This pull request passes (merged ee1c2a1 into 1b140b3).

@robashton
Copy link
Contributor Author

KK

@travisbot
Copy link

This pull request passes (merged ae1ec44 into 1b140b3).

matthewmueller added a commit that referenced this pull request Aug 19, 2012
Regression in removeClass (null ref)
@matthewmueller matthewmueller merged commit 1ea0c70 into cheeriojs:master Aug 19, 2012
@matthewmueller
Copy link
Member

Awesome! Thanks man for spotting and fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants