Fix errant dash instead of underscore in example of InSpec version #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tribute Signed-off-by: Gavin Reynolds <gavin@chef.io>
btm
approved these changes
Oct 11, 2018
|
travis failure is unrelated. |
|
Thank you Gavin and Bryan, merging |
btm
added a commit
that referenced
this pull request
Oct 11, 2018
I noticed a Travis failure on Ruby 2.2 on #340 But Ruby 2.2 was EOL six months ago: https://www.ruby-lang.org/en/news/2018/06/20/support-of-ruby-2-2-has-ended/ Chef 12 shipped with Ruby 2.1.2+ per https://github.com/chef/chef-rfc/blob/master/rfc015-chef-12.md#chef-12-1 Chef 12.14.11+ shipped with Ruby 2.3.1: chef/chef@505a2ba Chef 14.0.1+ shipped with Ruby 2.4+: chef/chef@aad8ccf126 We haven't shipped Ruby < 2.3 since 12.14 around August 2016. Signed-off-by: Bryan McLellan <btm@loftninjas.org>
Merged
btm
added a commit
that referenced
this pull request
Oct 11, 2018
I noticed a Travis failure on Ruby 2.2 on #340 But Ruby 2.2 was EOL six months ago: https://www.ruby-lang.org/en/news/2018/06/20/support-of-ruby-2-2-has-ended/ Chef 12 shipped with Ruby 2.1.2+ per https://github.com/chef/chef-rfc/blob/master/rfc015-chef-12.md#chef-12-1 Chef 12.14.11+ shipped with Ruby 2.3.1: chef/chef@505a2ba Chef 14.0.1+ shipped with Ruby 2.4+: chef/chef@aad8ccf126 We haven't shipped Ruby < 2.3 since 12.14 around August 2016. Signed-off-by: Bryan McLellan <btm@loftninjas.org>
alexpop
pushed a commit
that referenced
this pull request
Oct 11, 2018
I noticed a Travis failure on Ruby 2.2 on #340 But Ruby 2.2 was EOL six months ago: https://www.ruby-lang.org/en/news/2018/06/20/support-of-ruby-2-2-has-ended/ Chef 12 shipped with Ruby 2.1.2+ per https://github.com/chef/chef-rfc/blob/master/rfc015-chef-12.md#chef-12-1 Chef 12.14.11+ shipped with Ruby 2.3.1: chef/chef@505a2ba Chef 14.0.1+ shipped with Ruby 2.4+: chef/chef@aad8ccf126 We haven't shipped Ruby < 2.3 since 12.14 around August 2016. Signed-off-by: Bryan McLellan <btm@loftninjas.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InSpec version attribute should have an underscore, not a dash, in the README.
Signed-off-by: Gavin Reynolds gavin@chef.io