Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Ruby 2.2 support #341

Merged
merged 1 commit into from
Oct 11, 2018
Merged

Remove Ruby 2.2 support #341

merged 1 commit into from
Oct 11, 2018

Conversation

btm
Copy link
Contributor

@btm btm commented Oct 11, 2018

I noticed a Travis failure on Ruby 2.2 on #340
But Ruby 2.2 was EOL six months ago: https://www.ruby-lang.org/en/news/2018/06/20/support-of-ruby-2-2-has-ended/

Chef 12 shipped with Ruby 2.1.2+ per https://github.com/chef/chef-rfc/blob/master/rfc015-chef-12.md#chef-12-1
Chef 12.14.11+ shipped with Ruby 2.3.1: chef/chef@505a2ba
Chef 14.0.1+ shipped with Ruby 2.4+: chef/chef@aad8ccf126

We haven't shipped Ruby < 2.3 since 12.14 around August 2016.

@btm btm requested a review from a team October 11, 2018 14:30
I noticed a Travis failure on Ruby 2.2 on #340
But Ruby 2.2 was EOL six months ago: https://www.ruby-lang.org/en/news/2018/06/20/support-of-ruby-2-2-has-ended/

Chef 12 shipped with Ruby 2.1.2+ per https://github.com/chef/chef-rfc/blob/master/rfc015-chef-12.md#chef-12-1
Chef 12.14.11+ shipped with Ruby 2.3.1: chef/chef@505a2ba
Chef 14.0.1+ shipped with Ruby 2.4+: chef/chef@aad8ccf126

We haven't shipped Ruby < 2.3 since 12.14 around August 2016.

Signed-off-by: Bryan McLellan <btm@loftninjas.org>
@btm btm force-pushed the btm/remove-ruby-2.2 branch from 4f403c1 to a790f3a Compare October 11, 2018 14:31
Copy link
Contributor

@alexpop alexpop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch Bryan, thank you for digging up the timing of our ruby releases with chef-client.

@alexpop alexpop merged commit 3e64644 into master Oct 11, 2018
@btm btm deleted the btm/remove-ruby-2.2 branch October 11, 2018 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants