Update omnibus-overrides, switch to ruby 2.7 #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clintoncwolfe
force-pushed
the
cw/switch-to-ruby-2.7
branch
from
09b09c0
to
362ca10
Compare
33 tasks
tyler-ball
suggested changes
Apr 27, 2020
|
Deploy preview for chef-workstation ready! Built with commit 9b27255 |
tyler-ball
force-pushed
the
cw/switch-to-ruby-2.7
branch
3 times, most recently
from
42ab716
to
de7942e
Compare
tyler-ball
added a commit
to tyler-ball/rb-fsevent
that referenced
this pull request
Apr 29, 2020
We are currently in the [process](chef/chef-workstation#1123) of updating our package to use Ruby 2.7 which switched to using Bundler 2.x. We don't want to keep including bundler 1.x inside the package we generate so we have started going through and removing development dependencies on bundler. This works for us because all recent versions of Ruby include bundler (`gem install bundler` is unnecessary). `bundle install` in this directory still works. Our companies Ruby development has started removing bundler as a dev dependency to make the upgrade to Ruby 2.7 easier. Another option would be to remove the version specification, but that does cause a warning when doing `gem build`: ``` $ gem build rb-fsevent.gemspec WARNING: open-ended dependency on bundler (>= 0, development) is not recommended use a bounded requirement, such as '~> x.y' WARNING: See http://guides.rubygems.org/specification-reference/ for help ``` This is just a warning, but it is an annoying one. What would you think of either of these solutions?
tyler-ball
reviewed
Apr 29, 2020
| @@ -394,6 +394,9 @@ GEM | |||
| ffi (1.12.2) | |||
| ffi (1.12.2-x64-mingw32) | |||
| ffi (1.12.2-x86-mingw32) | |||
| ffi-compiler (1.0.1) | |||
There was a problem hiding this comment.
@tas50 @lamont-granquist Is this going to bite me in the ass?
There was a problem hiding this comment.
The new library which builds native extensions is https://github.com/cotag/http-parser which pulls in https://github.com/nodejs/http-parser/tree/77310eeb839c4251c07184a5db8885a572a08352 which is a C extension so... hopefully not?
tyler-ball
force-pushed
the
cw/switch-to-ruby-2.7
branch
3 times, most recently
from
9b17d95
to
7ce372d
Compare
tyler-ball
approved these changes
May 6, 2020
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
Signed-off-by: tyler-ball <tball@chef.io>
Also cleans up a rake error Signed-off-by: tyler-ball <tball@chef.io>
This has support for ed25519 keys correctly Signed-off-by: tyler-ball <tball@chef.io>
Signed-off-by: tyler-ball <tball@chef.io>
Signed-off-by: tyler-ball <tball@chef.io>
Signed-off-by: tyler-ball <tball@chef.io>
Signed-off-by: tyler-ball <tball@chef.io>
Ruby 2.7 ships with these, and we fixed issues in appbundler / the omnibus-toolchain to prevent installing multiple copies. Also bumped deps. Signed-off-by: tyler-ball <tball@chef.io>
…test versions Signed-off-by: tyler-ball <tball@chef.io>
Signed-off-by: tyler-ball <tball@chef.io>
Signed-off-by: tyler-ball <tball@chef.io>
Signed-off-by: tyler-ball <tball@chef.io>
This is an idea for potentially what we need to upgrade NodeJS Signed-off-by: tyler-ball <tball@chef.io>
Notes: chef/chef pulls nokogiri in using *only* an omnibus software definition. It is not in the Gemfile. So they are manually compiling the gem on all systems we distribute Chef to. We want to do the same thing. In Nokogiri 1.11.0 they started distributing a pre-compiled linux package (https://rubygems.org/gems/nokogiri/versions/1.11.0.rc2-x86_64-linux). We don't want to use that, or any of their pre-compiled gems. Unfortunately I cannot figure out how to get bundler to force Nokogiri to compile but also allow OTHER gems with pre-compiled extensions to be installed (like the -mingw32 gems). So, for now, after bundling I manually uninstall all versions of Nokogiri and then manually install the version that forces compilation. Maybe we could fix this by having a Windows-specific Gemfile that includes the -mingw32 gems, so all non-Windows systems force extension compilation for all gems via `BUNDLE_FORCE_RUBY_PLATFORM`? Signed-off-by: tyler-ball <tball@chef.io>
Signed-off-by: tyler-ball <tball@chef.io>
Signed-off-by: tyler-ball <tball@chef.io>
Non-Windows worked correctly with only specifying `env["NOKOGIRI_USE_SYSTEM_LIBRARIES"] = "true"` but Windows requires more. It doesn't hurt the other systems to do this, it is just unecessary there. Signed-off-by: tyler-ball <tball@chef.io>
Signed-off-by: tyler-ball <tball@chef.io>
Signed-off-by: tyler-ball <tball@chef.io>
tyler-ball
force-pushed
the
cw/switch-to-ruby-2.7
branch
from
fc8c260
to
9b27255
Compare
tas50
reviewed
May 6, 2020
| @@ -48,7 +47,6 @@ | |||
| ed25519.png | |||
| example | |||
| examples | |||
| ext | |||
There was a problem hiding this comment.
Was this for nokogiri or the http gem mess. This is going to bloat the builds pretty significantly.
There was a problem hiding this comment.
This was for the http gem - specifically without this it is missing http-parser-ext.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switches from ruby 2.6.5 to 2.7.1 and updates bundler and rubygems to match Chef Infra Client.
Related Issue
Part of #1059
Types of changes
Checklist:
Aha! Link: https://chef.aha.io/features/SH-1656