Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update omnibus-overrides, switch to ruby 2.7 #1123

Merged
merged 21 commits into from
May 6, 2020
Merged

Update omnibus-overrides, switch to ruby 2.7 #1123

merged 21 commits into from
May 6, 2020

Commits on May 6, 2020

  1. Switch to Ruby 2.7.1 

    Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
    @clintoncwolfe @tyler-ball
    clintoncwolfe authored and tyler-ball committed May 6, 2020
    Configuration menu
    Copy the full SHA
    74c2666 View commit details
    Browse the repository at this point in the history

  2. Update bundler and rubygems to match chef/chef 

    Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
    @clintoncwolfe @tyler-ball
    clintoncwolfe authored and tyler-ball committed May 6, 2020
    Configuration menu
    Copy the full SHA
    83e569b View commit details
    Browse the repository at this point in the history

  3. Adding Ruby 2.7 to testing pipeline 

    Signed-off-by: tyler-ball <tball@chef.io>
    @tyler-ball
    tyler-ball committed May 6, 2020
    Configuration menu
    Copy the full SHA
    4c88f82 View commit details
    Browse the repository at this point in the history

  4. Updating rake and minitest to version embedded in Ruby 

    Also cleans up a rake error

Signed-off-by: tyler-ball <tball@chef.io>
    @tyler-ball
    tyler-ball committed May 6, 2020
    Configuration menu
    Copy the full SHA
    b176173 View commit details
    Browse the repository at this point in the history

  5. Updating the bcrypt_pbkdf gem to the latest RC version 

    This has support for ed25519 keys correctly

Signed-off-by: tyler-ball <tball@chef.io>
    @tyler-ball
    tyler-ball committed May 6, 2020
    Configuration menu
    Copy the full SHA
    652f90f View commit details
    Browse the repository at this point in the history

  6. Updating rb-fsevent gem to remove dependency on bundler 

    Signed-off-by: tyler-ball <tball@chef.io>
    @tyler-ball
    tyler-ball committed May 6, 2020
    Configuration menu
    Copy the full SHA
    3aa55e8 View commit details
    Browse the repository at this point in the history

  7. Updating chef-telemetry, which pulls in http 4.x 

    Signed-off-by: tyler-ball <tball@chef.io>
    @tyler-ball
    tyler-ball committed May 6, 2020
    Configuration menu
    Copy the full SHA
    d05cf47 View commit details
    Browse the repository at this point in the history

  8. Updating omnibus deps 

    Signed-off-by: tyler-ball <tball@chef.io>
    @tyler-ball
    tyler-ball committed May 6, 2020
    Configuration menu
    Copy the full SHA
    cf45a97 View commit details
    Browse the repository at this point in the history

  9. Uncommenting some tests to see if they pass 

    Signed-off-by: tyler-ball <tball@chef.io>
    @tyler-ball
    tyler-ball committed May 6, 2020
    Configuration menu
    Copy the full SHA
    9389d45 View commit details
    Browse the repository at this point in the history

  10. Removing unecessary Rubygems and Bundler software deps 

    Ruby 2.7 ships with these, and we fixed issues in appbundler / the
omnibus-toolchain to prevent installing multiple copies.

Also bumped deps.

Signed-off-by: tyler-ball <tball@chef.io>
    @tyler-ball
    tyler-ball committed May 6, 2020
    Configuration menu
    Copy the full SHA
    26d0562 View commit details
    Browse the repository at this point in the history

  11. Updating nokogiri, chef-apply, chef-workstation-app, and nodejs to la… 

    …test versions

Signed-off-by: tyler-ball <tball@chef.io>
    @tyler-ball
    tyler-ball committed May 6, 2020
    Configuration menu
    Copy the full SHA
    2a86125 View commit details
    Browse the repository at this point in the history

  12. Updating to the latest chef-workstation-app 

    Signed-off-by: tyler-ball <tball@chef.io>
    @tyler-ball
    tyler-ball committed May 6, 2020
    Configuration menu
    Copy the full SHA
    ed94be7 View commit details
    Browse the repository at this point in the history

  13. Pinning Nokogiri since 1.11.0.rc2 fails to build 

    Signed-off-by: tyler-ball <tball@chef.io>
    @tyler-ball
    tyler-ball committed May 6, 2020
    Configuration menu
    Copy the full SHA
    20f8b31 View commit details
    Browse the repository at this point in the history

  14. Cannot upgrade to NodeJS > 11 until we drop EL 6 support 

    Signed-off-by: tyler-ball <tball@chef.io>
    @tyler-ball
    tyler-ball committed May 6, 2020
    Configuration menu
    Copy the full SHA
    a6ac415 View commit details
    Browse the repository at this point in the history

  15. Comment to help my future self out 

    This is an idea for potentially what we need to upgrade NodeJS

Signed-off-by: tyler-ball <tball@chef.io>
    @tyler-ball
    tyler-ball committed May 6, 2020
    Configuration menu
    Copy the full SHA
    f6566e2 View commit details
    Browse the repository at this point in the history

  16. Force Nokogiri to compile instead of installing pre-built extensions 

    Notes: chef/chef pulls nokogiri in using *only* an omnibus software
definition. It is not in the Gemfile. So they are manually compiling the
gem on all systems we distribute Chef to. We want to do the same thing.

In Nokogiri 1.11.0 they started distributing a pre-compiled linux
package (https://rubygems.org/gems/nokogiri/versions/1.11.0.rc2-x86_64-linux).
We don't want to use that, or any of their pre-compiled gems.
Unfortunately I cannot figure out how to get bundler to force Nokogiri
to compile but also allow OTHER gems with pre-compiled extensions to
be installed (like the -mingw32 gems).

So, for now, after bundling I manually uninstall all versions of
Nokogiri and then manually install the version that forces compilation.

Maybe we could fix this by having a Windows-specific Gemfile that
includes the -mingw32 gems, so all non-Windows systems force extension
compilation for all gems via `BUNDLE_FORCE_RUBY_PLATFORM`?

Signed-off-by: tyler-ball <tball@chef.io>
    @tyler-ball
    tyler-ball committed May 6, 2020
    Configuration menu
    Copy the full SHA
    1bd21d8 View commit details
    Browse the repository at this point in the history

  17. Updating to latest chef-cli release (support for .yml recipes) 

    Signed-off-by: tyler-ball <tball@chef.io>
    @tyler-ball
    tyler-ball committed May 6, 2020
    Configuration menu
    Copy the full SHA
    ae506b9 View commit details
    Browse the repository at this point in the history

  18. Don't delete native extension folders during cleanup 

    Signed-off-by: tyler-ball <tball@chef.io>
    @tyler-ball
    tyler-ball committed May 6, 2020
    Configuration menu
    Copy the full SHA
    59fe0a6 View commit details
    Browse the repository at this point in the history

  19. Windows Nokogiri requires specifying the lib paths 

    Non-Windows worked correctly with only specifying
`env["NOKOGIRI_USE_SYSTEM_LIBRARIES"] = "true"` but Windows requires
more. It doesn't hurt the other systems to do this, it is just unecessary
there.

Signed-off-by: tyler-ball <tball@chef.io>
    @tyler-ball
    tyler-ball committed May 6, 2020
    Configuration menu
    Copy the full SHA
    e78b07e View commit details
    Browse the repository at this point in the history

  20. Updating omnibus deps 

    Signed-off-by: tyler-ball <tball@chef.io>
    @tyler-ball
    tyler-ball committed May 6, 2020
    Configuration menu
    Copy the full SHA
    1b4e282 View commit details
    Browse the repository at this point in the history

  21. Unziping app has started failing, using ditto as recommended 

    Signed-off-by: tyler-ball <tball@chef.io>
    @tyler-ball
    tyler-ball committed May 6, 2020
    Configuration menu
    Copy the full SHA
    9b27255 View commit details
    Browse the repository at this point in the history