Merge pull request #623 from chewing/issue618

feat(editor): Revert mode switch notifications
chewing · Jul 20, 2024 · 73298c4 · 73298c4
2 parents 36af8a4 + 615046c
commit 73298c4
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 18 deletions.
diff --git a/capi/data/mini.dat b/capi/data/mini.dat
diff --git a/src/editor/mod.rs b/src/editor/mod.rs
@@ -242,7 +242,6 @@ impl Editor {
         self.shared.clear();
     }
     pub fn ack(&mut self) {
-        self.shared.notice_buffer.clear();
         self.shared.commit_buffer.clear();
     }
     pub fn clear_syllable_editor(&mut self) {
@@ -636,10 +635,6 @@ impl SharedState {
             },
             ..self.options
         };
-        match self.options.language_mode {
-            LanguageMode::Chinese => self.notice_buffer = format!("切換為中文模式"),
-            LanguageMode::English => self.notice_buffer = format!("切換為英數模式"),
-        }
     }
     fn switch_character_form(&mut self) {
         self.options = EditorOptions {
@@ -649,10 +644,6 @@ impl SharedState {
             },
             ..self.options
         };
-        match self.options.character_form {
-            CharacterForm::Halfwidth => self.notice_buffer = format!("切換為半形模式"),
-            CharacterForm::Fullwidth => self.notice_buffer = format!("切換為全形模式"),
-        }
     }
     fn cancel_selecting(&mut self) {
         self.com.pop_cursor();

diff --git a/tests/test-bopomofo.c b/tests/test-bopomofo.c
@@ -937,18 +937,11 @@ void test_Capslock()
     mode = chewing_get_ChiEngMode(ctx);
     ok(mode == SYMBOL_MODE, "mode shall change to SYMBOL_MODE");
 
-    ok_aux_buffer(ctx, "切換為英數模式");
-    ok_bopomofo_buffer(ctx, "");
-    ok_preedit_buffer(ctx, "");
-    ok_commit_buffer(ctx, "");
-
     type_keystroke_by_string(ctx, "<CB>");
 
     mode = chewing_get_ChiEngMode(ctx);
     ok(mode == CHINESE_MODE, "mode shall change to CHINESE_MODE");
 
-    ok_aux_buffer(ctx, "切換為中文模式");
-
     chewing_delete(ctx);
 }
 
@@ -1102,7 +1095,6 @@ void test_ShiftSpace()
     type_keystroke_by_string(ctx, "<SS>");
     mode = chewing_get_ShapeMode(ctx);
     ok(mode == FULLSHAPE_MODE, "mode shall be FULLSHAPE_MODE");
-    ok_aux_buffer(ctx, "切換為全形模式");
 
     type_keystroke_by_string(ctx, " ");
     ok_commit_buffer(ctx, "\xE3\x80\x80"); /* Fullshape Space (U+3000) */
@@ -1115,7 +1107,6 @@ void test_ShiftSpace()
     type_keystroke_by_string(ctx, "<SS>");
     mode = chewing_get_ShapeMode(ctx);
     ok(mode == HALFSHAPE_MODE, "mode shall be HALFSHAPE_MODE");
-    ok_aux_buffer(ctx, "切換為半形模式");
 
     type_keystroke_by_string(ctx, " ");
     ok_commit_buffer(ctx, " ");