Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement allauth #387

Draft
wants to merge 20 commits into
base: master
Choose a base branch
from
Draft

Implement allauth #387

wants to merge 20 commits into from

Conversation

GDay
Copy link
Member

@GDay GDay commented Nov 5, 2023

This will overwrite the custom implementation of MFA, OIDC and Google login. Still WIP.

To do:

  • Fix tests and add tests where necessary
  • Write migration script to:
    • Move recovery keys
    • Move totp secret
    • Make all existing emails verified
  • Add OIDC
  • Add Google login

@GDay GDay force-pushed the implement-allauth branch 2 times, most recently from 2dbb59c to 62071bf Compare November 7, 2023 22:18
@coveralls
Copy link
Collaborator

coveralls commented Nov 7, 2023

Coverage Status

coverage: 93.888% (+0.03%) from 93.854%
when pulling 5039816 on implement-allauth
into 20c45a9 on master.

@compgeniuses
Copy link

compgeniuses commented Jul 24, 2024

Hello, Whats the progress and status on this... Assesing its integration with https://github.com/DefGuard/defguard

with a Discussuion here

@GDay
Copy link
Member Author

GDay commented Jul 24, 2024

@compgeniuses I haven't worked on this in a while. Status is still the same, what still needs to be done:

  • Heavily manual testing
  • Bump allauth to latest version
  • Rebase and resolve conflicts

I don't have plans to work on this in near future, unless there is a financial incentive then I can put in my schedule (as mentioned here: #437 (comment)).

It would be good to get this checked by a second developer as it's auth based stuff, which is always a bit tricky. That person would also be paid from the donation to get this finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants