Merge pull request #156 from chingu-x/fix/form-response-boolean

Fix form responses giving error and not inserting values when the boolean value is false

CHANGELOG.md

@@ -67,6 +67,7 @@ Another example [here](https://co-pilot.dev/changelog)
 - Fix a bug in PATCH /meetings/{meetingId}/forms/{formId} where it's not accepting an array of responese (updated validation pipe, service, and tests) ([#121](https://github.com/chingu-x/chingu-dashboard-be/pull/121))
 - Fix unit tests where mocked req doesn't match new CustomRequest type ([#122](https://github.com/chingu-x/chingu-dashboard-be/pull/122))
 - Fix bug with reading roles after reseeding causes the db to not recognize the tokens stored by the user's browser ([#134](https://github.com/chingu-x/chingu-dashboard-be/pull/134))
+- Fix form responses giving error and not inserting values when the boolean value is false ([#156](https://github.com/chingu-x/chingu-dashboard-be/pull/156))
 
 ### Removed
 

src/global/global.service.ts

@@ -60,7 +60,7 @@ export class GlobalService {
                         ...(v.numeric
                             ? { numeric: v.numeric }
                             : { numeric: null }),
-                        ...(v.boolean
+                        ...(v.boolean !== undefined
                             ? { boolean: v.boolean }
                             : { boolean: null }),
                         ...(v.optionChoiceId

src/pipes/form-input-validation.ts

@@ -21,7 +21,7 @@ export class FormInputValidationPipe implements PipeTransform {
                     if (
                         !v.text &&
                         !v.numeric &&
-                        !v.boolean &&
+                        v.boolean === undefined &&
                         !v.optionChoiceId
                     )
                         throw new BadRequestException(

src/sprints/dto/create-checkin-form.dto.ts

@@ -1,6 +1,13 @@
 import { FormResponseDto } from "../../global/dtos/FormResponse.dto";
 import { ApiProperty } from "@nestjs/swagger";
-import { IsArray, IsNotEmpty, ValidateNested } from "class-validator";
+import {
+    IsArray,
+    IsNotEmpty,
+    IsNumber,
+    Max,
+    Min,
+    ValidateNested,
+} from "class-validator";
 import { Type } from "class-transformer";
 
 export class CreateCheckinFormDto {
@@ -16,6 +23,9 @@ export class CreateCheckinFormDto {
         example: 1,
     })
     @IsNotEmpty()
+    @IsNumber()
+    @Min(1)
+    @Max(6)
     sprintId: number;
 
     @ApiProperty({

src/sprints/sprints.service.ts

@@ -568,8 +568,6 @@ export class SprintsService {
             responsesArray,
         );
 
-        // TODO: do we need to check if sprintID is a reasonable sprint Id?
-
         try {
             const checkinSubmission = await this.prisma.$transaction(
                 async (tx) => {