Fix form responses giving error and not inserting values when the boolean value is false

[cherylli]

Description

When response is false, the validation pipe returns an error and the boolean value is also not inserted into the database properly

This is a new PR after renaming #154 as the branch name was causing issue for some members

Issue link

Fixes # (issue)

Type of change

• Bug fix (non-breaking change which fixes an issue)
• Feature updates / changes
• Tests
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

ran all the tests, send request from swagger and verified the values in the database

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules
• I have updated the change log

[cherylli]

New PR for #154 (branch rename)

[Ajen07]

All tests works fine . No error when the response is false and database is correctly updated for false values

[JoshuaHinman]

Tests passed and boolean false verified with swagger and prisma studio. One thing I was curious about: in the responseDtoToArray function, when pushing to the responsesArray, what do the spread operators do?

[cherylli]

Tests passed and boolean false verified with swagger and prisma studio. One thing I was curious about: in the responseDtoToArray function, when pushing to the responsesArray, what do the spread operators do?

@JoshuaHinman
Thanks for asking the question, I don't remember why I did that it seemed natural to me at the point, but then I did some research, it seems, with the spread operator, you can conditionally set the values
without spread operator, all have to be included in the push vs the alternative

for (const index in responses) {
    if (responseIndex.includes(index)) {
        responses[index].forEach((v: FormResponseDto) => {
            responsesArray.push({
                questionId: v.questionId,
                text: v.text,
                numeric: v.numeric,
                boolean: v.boolean,
                optionChoiceId: v.optionChoiceId,
            });
        });
    }
}

which probably did not matter if we have all these values inserted into the database (including nulls), I was trying to convert into the same structure as the input, but I think empty values are undefined coming from the res body, so I don't think we could just leave it as undefined as we can insert null into the database but not undefined(not tested, just my theory)

[JoshuaHinman]

it seems, with the spread operator, you can conditionally set the values
Thank you for explaining this - I don't recall seeing it before