Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update form input types #146

Merged
merged 2 commits into from
May 6, 2024
Merged

Update form input types #146

merged 2 commits into from
May 6, 2024

Conversation

cherylli
Copy link
Contributor

@cherylli cherylli commented May 5, 2024

Description

Added some form input types to make it easier for frontend to render the display

Please check this document out on confluence for descriptions of all input types
https://suwanna.atlassian.net/wiki/spaces/SD/pages/79888385/Input+Types

Issue link

https://app.clickup.com/t/86b0ab2dh

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature updates / changes
  • Tests
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

ran prisma db seed with no error

image

image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have updated the change log

@cherylli cherylli self-assigned this May 5, 2024
timDeHof
timDeHof approved these changes May 5, 2024
View reviewed changes
Copy link
Contributor

@timDeHof timDeHof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! All the tests pass on my end. I can't wait to see how this translates to frontend.

Ajen07
Ajen07 approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@Ajen07 Ajen07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes looks good and all the unit tests and e2e tests are passed on my side.

@cherylli cherylli merged commit 61ddd65 into dev May 6, 2024
1 check passed
@cherylli cherylli deleted the chore/update-form-input-types branch May 6, 2024 11:49
timDeHof added a commit that referenced this pull request May 9, 2024
@timDeHof
chore(CHANGELOG.md): update changelog with new feature and fix
40698c9 
The changelog has been updated to include the following changes:
- A new feature has been added to the deleteFeature method. It now uses a DeleteFeatureResponse and returns an object with a successful status and a message. This change was made in pull request #150.
- Various updates and additions have been made to the test github actions workflow, form title references, and form input types. These changes were made in pull requests #143, #145, and #146 respectively.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ajen07 Ajen07 Ajen07 approved these changes

@timDeHof timDeHof timDeHof approved these changes

@JoshuaHinman JoshuaHinman Awaiting requested review from JoshuaHinman

@curtwl curtwl Awaiting requested review from curtwl

Assignees

@cherylli cherylli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cherylli @timDeHof @Ajen07