Introduce DeleteFeatureResponse and update deleteFeature method with a status code and a message #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r feature deletion fix(features): update deleteFeature method in FeaturesService to return a proper response object The DeleteFeatureResponse class is added to handle the response for feature deletion. It includes a message and statusCode property. The deleteFeature method in FeaturesService is updated to return a response object with a success message and status code of 200 when a feature is successfully deleted. This improves the consistency and clarity of the code when handling feature deletion.
The changelog has been updated to include the following changes: - A new feature has been added to the deleteFeature method. It now uses a DeleteFeatureResponse and returns an object with a successful status and a message. This change was made in pull request #150. - Various updates and additions have been made to the test github actions workflow, form title references, and form input types. These changes were made in pull requests #143, #145, and #146 respectively.
cherylli
approved these changes
May 9, 2024
Ajen07
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces a new DeleteFeatureResponse class to handle the response for feature deletion scenarios. The class includes a message and statusCode property, which will provide a consistent and clear response when deleting a feature.
The deleteFeature method in the FeaturesService has also been updated to return an instance of the newly added DeleteFeatureResponse class. When a feature is successfully deleted, the method will return a response object with a success message and a status code of 200.
Issue link
Fixes # https://app.clickup.com/t/86b07bdar
Type of change
How Has This Been Tested?
Since the features don't have any tests for them yet. you have to test this endpoint in swagger by login as the default user and type
7for the featureId, which should give a 200 response status and message.Checklist: