Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase runtime stack size to 64KiB #1784

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

clundin25
Copy link
Contributor

No description provided.

Copy link
Collaborator

@mhatrevi mhatrevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the motivation for this much increase in stack size? Reducing the DATA_SIZE to 22 K will be insufficient for storing Caliptra 2.0 MLDSA related artifacts (TBSes, public keys, signatures etc)

@clundin25
Copy link
Contributor Author

What is the motivation for this much increase in stack size? Reducing the DATA_SIZE to 22 K will be insufficient for storing Caliptra 2.0 MLDSA related artifacts (TBSes, public keys, signatures etc)

The current maximum observed stack usage is ~54,208 bytes.

After this series of PRs is merged, I will add #1785 to prevent increases in stack usage.

With that in place we can work on reducing the stack usage. I think 48KiB can be obtainable relatively quickly.

@clundin25 clundin25 requested a review from mhatrevi November 13, 2024 22:05
@jhand2
Copy link
Collaborator

jhand2 commented Nov 13, 2024

What is the motivation for this much increase in stack size? Reducing the DATA_SIZE to 22 K will be insufficient for storing Caliptra 2.0 MLDSA related artifacts (TBSes, public keys, signatures etc)

This is more of a reflection of reality than an actual increase. But ya, as Carl said, we will continue work to reduce stack usage.

@jhand2 jhand2 enabled auto-merge (rebase) November 14, 2024 00:38
@jhand2 jhand2 merged commit 0cc6ca8 into chipsalliance:main Nov 14, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants