Add stack overflow detection to sw-emulator #1785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clundin25
force-pushed
the
stack-overflow-monitor
branch
from
6534995 to
15c3882
Compare
clundin25
requested review from
korran,
fdamato,
jlmahowa-amd,
mhatrevi,
jhand2,
swenson,
vsonims,
rusty1968,
bluegate010,
ajisaxena and
JohnTraverAmd
as code owners
clundin25
commented
Nov 14, 2024
clundin25
force-pushed
the
stack-overflow-monitor
branch
from
15c3882 to
c1836a9
Compare
clundin25
force-pushed
the
stack-overflow-monitor
branch
from
c1836a9 to
d6f8397
Compare
jhand2
reviewed
Dec 2, 2024
clundin25
force-pushed
the
stack-overflow-monitor
branch
from
d6f8397 to
a99ab23
Compare
clundin25
force-pushed
the
stack-overflow-monitor
branch
from
a99ab23 to
eca5e52
Compare
jhand2
reviewed
Dec 4, 2024
jhand2
approved these changes
Dec 4, 2024
mhatrevi
approved these changes
Dec 5, 2024
swenson
reviewed
Dec 6, 2024
| @@ -262,7 +401,24 @@ impl<TBus: Bus> Cpu<TBus> { | |||
| /// | |||
| /// * `RvException` - Exception with cause `RvExceptionCause::IllegalRegister` | |||
| pub fn write_xreg(&mut self, reg: XReg, val: RvData) -> Result<(), RvException> { | |||
| self.xregs.write(reg, val) | |||
| // XReg::X2 is the sp register. | |||
| if reg == XReg::X2 { | |||
There was a problem hiding this comment.
Theoretically, we can set the sp to another value as a temporary, or when initializing (we set it to 0 at the beginning of the ROM), and this isn't necessarily a stack overflow, so we might have to be a little careful here.
swenson
reviewed
Dec 6, 2024
| @@ -262,7 +401,24 @@ impl<TBus: Bus> Cpu<TBus> { | |||
| /// | |||
| /// * `RvException` - Exception with cause `RvExceptionCause::IllegalRegister` | |||
| pub fn write_xreg(&mut self, reg: XReg, val: RvData) -> Result<(), RvException> { | |||
| self.xregs.write(reg, val) | |||
| // XReg::X2 is the sp register. | |||
There was a problem hiding this comment.
It might be good to document why this works: LLVM appears to always pre-allocate the stack by subtracting, and then using only positive relative offsets to SP. (Is that guaranteed though?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added stack monitoring and overflow detection to the SW emulator
If a stack overflow is detected, the emulator will panic and cause test failure.
This resolves #1735