-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Deprecated Usages of chisel3.Driver, CircuitForm #1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chick
approved these changes
Jun 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ouch, And I thought reviewing Firrtl PR #1700 was bad.
There are couple nits but this looks ready to go to me.
Adds a new method, chiselTests.Util.containsCause, that will search for a polymorphic exception anywhere in a stack trace. This is useful if exceptions may move around (e.g., if they are suddenly wrapped in a StageError). Signed-off-by: Schuyler Eldridge <schuyler.eldridge@ibm.com>
This migrates the tests to Chisel 3.4/FIRRTL 1.4. This primarily involves removing usages of deprecated methods including: - Remove usages of Driver - Use ChiselStage methods instead of BackendCompilationUtilities methods - Use Dependency API for custom transforms - Use extractCause to unpack StackError Signed-off-by: Schuyler Eldridge <schuyler.eldridge@ibm.com>
Signed-off-by: Schuyler Eldridge <schuyler.eldridge@ibm.com>
Signed-off-by: Schuyler Eldridge <schuyler.eldridge@ibm.com>
Signed-off-by: Schuyler Eldridge <schuyler.eldridge@ibm.com>
Signed-off-by: Schuyler Eldridge <schuyler.eldridge@ibm.com>
Co-authored-by: Chick Markley <chick@qrhino.com> Co-authored-by: Schuyler Eldridge <schuyler.eldridge@ibm.com> Signed-off-by: Schuyler Eldridge <schuyler.eldridge@ibm.com>
Signed-off-by: Schuyler Eldridge <schuyler.eldridge@ibm.com>
seldridge
force-pushed
the
driver-deprecations
branch
from
June 23, 2020 00:00
9609265
to
b5e5989
Compare
seldridge
added a commit
that referenced
this pull request
Jun 23, 2020
…1492) * Add containsCause exception search testing util * Use ChiselStage in Tests * Remove Driver usage in Emitter * Remove Driver usage in ChiselSpec * Remove Driver usage from Chisel._ package * Deprecate Driver Execution classes * Code simplification in internal Chisel._ method * Clarify chiselTests.Utils.extractCause Scaladoc Co-authored-by: Chick Markley <chick@qrhino.com> Co-authored-by: Schuyler Eldridge <schuyler.eldridge@ibm.com> Signed-off-by: Schuyler Eldridge <schuyler.eldridge@ibm.com>
Unfortunately, this commit (and its 3.3.x backport #1492) appear to cause chisel-testers to break:
with failures such as:
|
seldridge
added a commit
that referenced
this pull request
Jun 24, 2020
This reverts TesterDriver.scala changes from 6e03f63.
seldridge
added a commit
that referenced
this pull request
Jun 24, 2020
This reverts TesterDriver.scala changes from 6e03f63.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts all tests to not use Chisel 3.3/FIRRTL 1.3 deprecated features, including:
ChiselStage
methods are used instead of those in theBackendCompilationUtilities
trait, e.g., for elaborationchisel3.Driver
are removedIn doing this, a new utility is added to extract a specific cause type from a stack trace:
extractCause[A <: Throwable : ClassTag]
, is added that rethrows a nestedA
if it existsA few deprecations are added:
Driver
infrastructure (e.g.,ChiselExecutionResult
) is deprecatedRelated issue:
Type of change: other enhancement
Impact: no functional change
Development Phase: implementation
Release Notes
None.