Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links in docs #1643

Merged
merged 1 commit into from
Oct 27, 2020
Merged

Fix broken links in docs #1643

merged 1 commit into from
Oct 27, 2020

Conversation

azidar
Copy link
Contributor

@azidar azidar commented Oct 27, 2020

Contributor Checklist

Type of Improvement

  • documentation

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (3.2.x, 3.3.x, 3.4.0, 3.5.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@azidar azidar requested a review from a team as a code owner October 27, 2020 20:47
@azidar azidar requested review from ducky64 and removed request for a team October 27, 2020 20:47
@azidar azidar added this to the 3.4.x milestone Oct 27, 2020
Copy link
Contributor

@ducky64 ducky64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a fix. The links don't seem to work within the GitHub interface (missing the .md extension), but I assume this is generating to some other target?

@azidar
Copy link
Contributor Author

azidar commented Oct 27, 2020

Ugh. If it has the .md interface, then the website is broken. If it doesn't, then the github interface is broken....

Perhaps I need to spend more time figuring this out.

@azidar
Copy link
Contributor Author

azidar commented Oct 27, 2020

Ok for now its better to break github than the website, so i'll merge and try and find a permanent fix later.

@azidar azidar merged commit 362a3e3 into master Oct 27, 2020
mergify bot pushed a commit that referenced this pull request Oct 27, 2020
(cherry picked from commit 362a3e3)
@mergify mergify bot added the Backported This PR has been backported label Oct 27, 2020
mergify bot added a commit that referenced this pull request Oct 27, 2020
(cherry picked from commit 362a3e3)

Co-authored-by: Adam Izraelevitz <azidar@gmail.com>
@jackkoenig jackkoenig deleted the fix-crosslink branch July 7, 2021 03:44
jackkoenig pushed a commit that referenced this pull request Feb 28, 2023
* Add attributes, ifdefs to emitter.

* Make ifdef API a little cleaner.

* Remove references to ifdefs.

* Remove more of the ifdef stuff I missed

* Fix up failing tests

* Add multiple attribute test case

* Remove tpe as a parameter from Annotations.

Some general refactoring.

* Add some documentation.

* Incorporate some feedback

* Expand some spaghetti code, add comments

* Fix type signature by removing it

* bug fix in test

* Fix unchecked type parameter matches in AddDescriptionNodes.

* use target to replace name

Co-authored-by: Paul Rigge <rigge@berkeley.edu>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported This PR has been backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants