Improve source locators for switch statements. #1669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
seldridge
approved these changes
Nov 13, 2020
|
@jackkoenig: Can this be backported and how far? This is adding a second parameter group which I think will break backwards compatibility? |
jackkoenig
added a commit
that referenced
this pull request
Feb 28, 2023
* Build ArrayBuffers in Block.mapStmt * Have empty Block serialize as "skip" The FIRRTL parser requires at least one indented line in each module. Sometimes tests emit and parse modules with no contents; this ensures there's always at least a "skip" in empty modules. Also fix tests that expected certain skips * Use var List as stack in Block.mapStmt impl This replaces Iterator concatenation. In Scala 2.11, RHS recursion on Iterators is not stack safe. This seems to have been fixed in 2.12 by Scala PR 5033. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1648.
Contributor Checklist
Did you add Scaladoc to every public function/method?Did you add appropriate documentation indocs/src?Did you add text to be included in the Release Notes for this change?Type of Improvement
API Impact
No impact.
Backend Code Generation Impact
The source locators in the code generated from the
switchstatements will no longer referenceConditional.scala. They will now reference the source line of theisstatement.Desired Merge Strategy
Release Notes
N/A
Reviewer Checklist (only modified by reviewer)
Please Merge?