Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reported width from div/rem to match FIRRTL results (bp #1748) #1768

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 1, 2021

This is an automatic backport of pull request #1748 done by Mergify.

Cherry-pick of 98ce919 has failed:

On branch mergify/bp/3.2.x/pr-1748
Your branch is up to date with 'origin/3.2.x'.

You are currently cherry-picking commit 98ce9194.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   chiselFrontend/src/main/scala/chisel3/Bits.scala
	modified:   src/test/scala/chiselTests/SIntOps.scala
	modified:   src/test/scala/chiselTests/UIntOps.scala
	modified:   src/test/scala/chiselTests/WidthSpec.scala

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   core/src/main/scala/chisel3/internal/firrtl/IR.scala

To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

* Update reported width from div/rem to match FIRRTL results

* Add tests for width of % and / on UInt and SInt

* Add loop-based test for known UInt/SInt op result widths

Co-authored-by: Jack Koenig <koenig@sifive.com>
(cherry picked from commit 98ce919)

# Conflicts:
#	core/src/main/scala/chisel3/internal/firrtl/IR.scala
@mergify mergify bot added bp-conflict Backport Automated backport, please consider for minor release labels Feb 1, 2021
@jackkoenig
Copy link
Contributor

Closing all backports to versions older than 3.4.x

@jackkoenig jackkoenig closed this Mar 18, 2023
@mergify mergify bot deleted the mergify/bp/3.2.x/pr-1748 branch March 18, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport Automated backport, please consider for minor release bp-conflict
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants