Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SemanticDB requires private fields of case class to use "val" #3270

Merged
merged 1 commit into from
May 9, 2023
Merged

SemanticDB requires private fields of case class to use "val" #3270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/scala/chisel3/experimental/hierarchy/core/Definition.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import scala.annotation.nowarn
*
* @param underlying The internal representation of the definition, which may be either be directly the object, or a clone of an object
*/
final case class Definition[+A] private[chisel3] (private[chisel3] underlying: Underlying[A])
final case class Definition[+A] private[chisel3] (private[chisel3] val underlying: Underlying[A])
extends IsLookupable
with SealedHierarchy[A] {

Expand Down
3 changes: 2 additions & 1 deletion core/src/main/scala/chisel3/experimental/hierarchy/core/Instance.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ import scala.annotation.nowarn
*
* @param underlying The internal representation of the instance, which may be either be directly the object, or a clone of an object
*/
final case class Instance[+A] private[chisel3] (private[chisel3] underlying: Underlying[A]) extends SealedHierarchy[A] {
final case class Instance[+A] private[chisel3] (private[chisel3] val underlying: Underlying[A])
extends SealedHierarchy[A] {
underlying match {
case Proto(p: IsClone[_]) => chisel3.internal.throwException("Cannot have a Proto with a clone!")
case other => //Ok
Expand Down