Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix emitted FIRRTL for dynamic index of size 0 Vec #4275

Merged
merged 1 commit into from
Jul 13, 2024
Merged

Fix emitted FIRRTL for dynamic index of size 0 Vec #4275

merged 1 commit into from
Jul 13, 2024

Conversation

jackkoenig
Copy link
Contributor

#4268 introduced a subtle bug for when dynamically indexing Vecs of size 0. This is currently deprecated but obviously we need to emit legal FIRRTL until it becomes an error.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Bugfix (but no release notes because this bug isn't released)

Desired Merge Strategy

  • Squash

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@jackkoenig jackkoenig added the No Release Notes Exclude from release notes, consider using Internal instead label Jul 12, 2024
@jackkoenig jackkoenig added this to the 6.x milestone Jul 12, 2024
@jackkoenig jackkoenig force-pushed the jackkoenig/fix-index-size-0-vec branch from c3fc6c0 to 33b59d7 Compare July 12, 2024 19:41
seldridge
seldridge approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks fine.

core/src/main/scala/chisel3/Aggregate.scala Outdated Show resolved Hide resolved
core/src/main/scala/chisel3/Aggregate.scala Outdated Show resolved Hide resolved
@jackkoenig jackkoenig force-pushed the jackkoenig/fix-index-size-0-vec branch from 33b59d7 to 3612b74 Compare July 12, 2024 22:31
@jackkoenig
Fix emitted FIRRTL for dynamic index of size 0 Vec
040d7ec 
This is currently a warning but not yet an error so we need to emit
legal FIRRTL.
@jackkoenig jackkoenig force-pushed the jackkoenig/fix-index-size-0-vec branch from 3612b74 to 040d7ec Compare July 12, 2024 23:47
@jackkoenig jackkoenig enabled auto-merge (squash) July 12, 2024 23:49
@jackkoenig jackkoenig merged commit d5ccf48 into main Jul 13, 2024
13 checks passed
@jackkoenig jackkoenig deleted the jackkoenig/fix-index-size-0-vec branch July 13, 2024 00:02
@mergify mergify bot added the Backported This PR has been backported label Jul 13, 2024
mergify bot pushed a commit that referenced this pull request Jul 13, 2024
@jackkoenig @mergify
Fix emitted FIRRTL for dynamic index of size 0 Vec (#4275)
0bb2d80 
This is currently a warning but not yet an error so we need to emit
legal FIRRTL.

(cherry picked from commit d5ccf48)
@mergify mergify bot mentioned this pull request Jul 13, 2024
Merged
14 tasks
chiselbot pushed a commit that referenced this pull request Jul 13, 2024
@mergify @jackkoenig
Fix emitted FIRRTL for dynamic index of size 0 Vec (#4275) (#4276)
62106e9 
This is currently a warning but not yet an error so we need to emit
legal FIRRTL.

(cherry picked from commit d5ccf48)

Co-authored-by: Jack Koenig <koenig@sifive.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seldridge seldridge seldridge approved these changes

Assignees
No one assigned
Labels
Backported This PR has been backported No Release Notes Exclude from release notes, consider using Internal instead
Projects
None yet
Milestone
6.x
Development

Successfully merging this pull request may close these issues.
2 participants
@jackkoenig @seldridge