Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix emitted FIRRTL for dynamic index of size 0 Vec (backport #4275) #4276

Merged
merged 1 commit into from
Jul 13, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 13, 2024

#4268 introduced a subtle bug for when dynamically indexing Vecs of size 0. This is currently deprecated but obviously we need to emit legal FIRRTL until it becomes an error.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Bugfix (but no release notes because this bug isn't released)

Desired Merge Strategy

  • Squash

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

This is an automatic backport of pull request #4275 done by [Mergify](https://mergify.com).

This is currently a warning but not yet an error so we need to emit
legal FIRRTL.

(cherry picked from commit d5ccf48)
@mergify mergify bot added the Backport Automated backport, please consider for minor release label Jul 13, 2024
@github-actions github-actions bot added the No Release Notes Exclude from release notes, consider using Internal instead label Jul 13, 2024
@chiselbot chiselbot merged commit 62106e9 into 6.x Jul 13, 2024
17 checks passed
@chiselbot chiselbot deleted the mergify/bp/6.x/pr-4275 branch July 13, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport Automated backport, please consider for minor release No Release Notes Exclude from release notes, consider using Internal instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants