Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape % in assertion messages #500

Merged
merged 1 commit into from
Feb 24, 2017
Merged

Escape % in assertion messages #500

merged 1 commit into from
Feb 24, 2017

Conversation

jackkoenig
Copy link
Contributor

Note that currently assertions with % in the message or in the line or with % in the filename will all fail to compile

@colinschmidt
Copy link
Contributor

Are there any other things we need to escape?

@jackkoenig
Copy link
Contributor Author

I don't think so, regular escape characters come already escaped in Scala. % is the only format specifier so it should be the only thing from Scala strings we have to explicitly escape.

Side note, I need to implement assertions accepting Printables so people can print useful diagnostic information easily.

Copy link
Contributor

@colinschmidt colinschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after conflicts fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants