Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix getWidth on empty Vecs; add test #561

Merged
merged 1 commit into from
Mar 24, 2017
Merged

Fix getWidth on empty Vecs; add test #561

merged 1 commit into from
Mar 24, 2017

Conversation

aswaterman
Copy link
Member

Use fold(0) instead of reduce to handle the corner case.

@aswaterman
Fix getWidth on empty Vecs; add test
3e5563c 
Use fold(0) instead of reduce to handle the corner case.
@aswaterman aswaterman requested a review from ducky64 March 24, 2017 22:18
@aswaterman aswaterman closed this Mar 24, 2017
@aswaterman aswaterman deleted the vec-zero-width branch March 24, 2017 22:19
@aswaterman aswaterman restored the vec-zero-width branch March 24, 2017 22:36
@aswaterman aswaterman reopened this Mar 24, 2017
ducky64
ducky64 approved these changes Mar 24, 2017
View reviewed changes
Copy link
Contributor

@ducky64 ducky64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aswaterman aswaterman merged commit e769e5a into master Mar 24, 2017
@aswaterman aswaterman deleted the vec-zero-width branch March 24, 2017 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ducky64 ducky64 ducky64 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aswaterman @ducky64